File TokenData.php has 402 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
*
* @package GemsGems_Util_TokenData has 29 functions (exceeds 20 allowed). Consider refactoring. Open
class Gems_Util_TokenData extends \MUtil_Translate_TranslateableAbstract
{
/**
*
* @var \Gems_User_UserThe class Gems_Util_TokenData has an overall complexity of 93 which is very high. The configured complexity threshold is 50. Open
class Gems_Util_TokenData extends \MUtil_Translate_TranslateableAbstract
{
/**
*
* @var \Gems_User_User- Exclude checks
Method getStatusIcons has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getStatusIcons()
{
static $status;
if (is_null($status)) {Function getTokenAskButton has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function getTokenAskButton($tokenId, $tokenStatus, $staffToken, $keepCaps)
{
if ('O' == $tokenStatus || 'P' == $tokenStatus) {
if ($staffToken) {
$menuItem = $this->_getAskMenuItem();- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getTokenStatusLink has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getTokenStatusLink($tokenId, $tokenStatus, $patientNr, $roundDescr, $surveyName, $result)Method getTokenStatusTitle has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getTokenStatusTitle($tokenId, $tokenStatus, $patientNr, $roundDescr, $surveyName, $result)Avoid too many return statements within this method. Open
return 'waiting';Avoid too many return statements within this method. Open
return 'open';Avoid too many return statements within this method. Open
return 'grc_success = 1 AND gto_completion_time IS NULL AND (gto_valid_until IS NULL OR gto_valid_until >= CURRENT_TIMESTAMP) AND gto_in_source = 1';Avoid too many return statements within this method. Open
return 'empty';Avoid too many return statements within this method. Open
return 'grc_success = 1 AND gto_completion_time IS NULL AND gto_in_source = 0 AND gto_valid_until < CURRENT_TIMESTAMP';Avoid too many return statements within this method. Open
return 'grc_success = 1 AND gto_completion_time IS NULL AND (gto_valid_until IS NULL OR gto_valid_until >= CURRENT_TIMESTAMP) AND gto_in_source = 0';Avoid too many return statements within this method. Open
return 'unknown';Avoid too many return statements within this method. Open
return 'grc_success = 1 AND gto_completion_time IS NULL AND gto_in_source = 1 AND gto_valid_until < CURRENT_TIMESTAMP';Avoid unused parameters such as '$addDescription'. Open
public function getTokenStatusDescriptionForBridge(\MUtil_Model_Bridge_TableBridgeAbstract $bridge, $addDescription = false)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Similar blocks of code found in 2 locations. Consider refactoring. Open
$status = array(
'U' => $this->_('Valid from date unknown'),
'W' => $this->_('Valid from date in the future'),
'O' => $this->_('Open - can be answered now'),
'P' => $this->_('Open - partially answered'),- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 96.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76