Genshin/GenSheet

View on GitHub

Showing 3 of 3 total issues

Method _set_data_to_xls has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def _set_data_to_xls(xls, outsheets, originalsheets, names)
    # Take out the merged data that is separate
    worksheets = @workbook.instance_variable_get('@worksheets')
    merges = _get_merge_data(worksheets) unless worksheets.nil?

Severity: Minor
Found in lib/GenSheetExporters.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _get_format_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def _get_format_data(xls, cells, merge)
    cells.each do |cell|
      format = _set_format(xls, cell.format) unless cell.format.nil?

      # add format when merged cell
Severity: Minor
Found in lib/GenSheetExporters.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _set_format has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def _set_format(xls, font)
    format = xls.add_format(
      # :bottom => 1,      #
      # :top => 1,         # border
      # :left => 1,        #
Severity: Minor
Found in lib/GenSheetExporters.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language