Showing 10 of 20 total issues
Class Base has 23 methods (exceeds 20 allowed). Consider refactoring. Open
class Base
attr_accessor :frames, :width, :height, :loops, :skip_first
def initialize(path = nil, options = {})
resetClass SVGWriter has 21 methods (exceeds 20 allowed). Consider refactoring. Open
class SVGWriter < AbstractImageWriter
# Write svg file from object to path.
# Return write size.
def write(path, object)
return 0 if path.nil? || path.empty? || object.nil?Method combine has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
def combine(path)
src = Base.new(path, {unique_ids: true})
if @width != src.width || @height != src.height
fail "Can't combine source images of different sizes."Method set_width has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def set_width(width)
if width.nil?
if @width.nil? || @width == 0
frames.each do |frame|
@width = frame.width.to_i if frame.width.to_i > @width- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set_height has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def set_height(height)
if height.nil?
if @height.nil? || @height == 0
frames.each do |frame|
@height = frame.height.to_i if frame.height.to_i > @height- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method write_proc has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def write_proc(object)
if object.is_a?(Base)
if object.frames.size == 1 then write_svg(object.frames[0])
elsif object.frames.size > 1 then write_animation_svg(object)
else return false- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method combine has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def combine(path)
src = Base.new(path, {unique_ids: true})
if @width != src.width || @height != src.height
fail "Can't combine source images of different sizes."- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create_file_list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def create_file_list(path)
result = Dir.glob(path).sort_by { |k| k[/\d+/].to_i }
if result.empty?
result <<
if File.exist?(path) then path- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create_frames has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def create_frames
i = 0
@frame_infos.each do |frame_info|
create_file_list(frame_info[:name]).each do |file|
reader = Parser::SVGReader.new(file, create_options(i, frame_info[:delay]))- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method _replace_id_refs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def _replace_id_refs(id, new_id)
@root.elements.each("//*") do |element|
element.attributes['style'].gsub!(/url\(\##{id}\)/, "url(\##{new_id})") if element.attributes['style'] != nil
element.attributes['fill'].gsub!(/\##{id}$/, "\##{new_id}") if element.attributes['fill'] != nil
element.attributes['xlink:href'].gsub!(/\##{id}$/, "\##{new_id}") if element.attributes['xlink:href'] != nil- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"