Sign upLogin

GeriLife/caregiving

View on GitHub
Star

Showing 155 of 166 total issues

File models.py has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import datetime
from typing import TYPE_CHECKING
from django.contrib.auth import get_user_model
from django.db.models import Count, Q, QuerySet
from django.utils import timezone
Severity: Minor
Found in homes/models.py - About 5 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        def get_object(self, queryset=None):
            if queryset is None:
                queryset = self.get_queryset()
     
            url_uuid = self.kwargs.get("url_uuid")  # Get the url_uuid from the URL
    Severity: Major
    Found in residents/views.py and 1 other location - About 4 hrs to fix
    residents/views.py on lines 26..41

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        def get_object(self, queryset=None):
            if queryset is None:
                queryset = self.get_queryset()
     
            url_uuid = self.kwargs.get("url_uuid")  # Get the url_uuid from the URL
    Severity: Major
    Found in residents/views.py and 1 other location - About 4 hrs to fix
    residents/views.py on lines 71..86

    Function get_resident_percents_by_activity_level_normalized has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_resident_percents_by_activity_level_normalized(self) -> dict[str, float]:
            """Returns the resident counts by activity level annotated with a
            percent.
     
            The percent values, when rounded to the nearest integer, should
    Severity: Minor
    Found in homes/models.py - About 2 hrs to fix

    Cyclomatic complexity is too high in method get_resident_percents_by_activity_level_normalized. (10)
    Open

        def get_resident_percents_by_activity_level_normalized(self) -> dict[str, float]:
            """Returns the resident counts by activity level annotated with a
            percent.
     
            The percent values, when rounded to the nearest integer, should
    Severity: Minor
    Found in homes/models.py by radon

    File charts.py has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    from django.db.models import Sum
    from django.utils.translation import gettext as _
     
    import pandas as pd
    import plotly.express as px
    Severity: Minor
    Found in homes/charts.py - About 2 hrs to fix

      Cyclomatic complexity is too high in method post. (8)
      Open

          @transaction.atomic
          def post(self, request, *args, **kwargs):
              """Override the post method to add the resident activity in the same
              transaction as the activity."""
              form = self.get_form()
      Severity: Minor
      Found in activities/views.py by radon

      Cyclomatic complexity is too high in method resident_counts_by_activity_level. (6)
      Open

          @property
          def resident_counts_by_activity_level(self) -> dict[str, int]:
              """Returns a dictionary of counts of residents by activity level."""
       
              annotated_residents = self.residents_with_recent_activity_counts
      Severity: Minor
      Found in homes/models.py by radon

      Cyclomatic complexity is too high in method handle. (6)
      Open

          def handle(self, *args, **options):
              with transaction.atomic():
                  homes = HomeFactory.create_batch(NUM_HOMES)
                  today = datetime.date.today()
       
       
      Severity: Minor
      Found in common/management/commands/make_fake_data.py by radon

      Cyclomatic complexity is too high in function _structure_resident_data. (6)
      Open

      def _structure_resident_data(
          pivot_result: pd.DataFrame,
          current_residents: QuerySet,
          date_range: list[datetime.date],
      ) -> dict:
      Severity: Minor
      Found in homes/models.py by radon

      Cyclomatic complexity is too high in class Command. (6)
      Open

      class Command(BaseCommand):
          help = "Creates fake homes, residents, residencies, and resident activities."
       
          def handle(self, *args, **options):
              with transaction.atomic():
      Severity: Minor
      Found in common/management/commands/make_fake_data.py by radon

      Function post has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def post(self, request, *args, **kwargs):
              """Override the post method to add the resident activity in the same
              transaction as the activity."""
              form = self.get_form()
              is_form_valid = form.is_valid()
      Severity: Minor
      Found in activities/views.py - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      Severity: Major
      Found in activities/urls.py and 1 other location - About 1 hr to fix
      work/urls.py on lines 0..7

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      Severity: Major
      Found in work/urls.py and 1 other location - About 1 hr to fix
      activities/urls.py on lines 0..14

      Avoid deeply nested control flow statements.
      Open

                              if rounded_percents.sum() == 100:
                                  break
       
                  # Update the activity_counts dictionary with the adjusted percentages
                  keys = [
      Severity: Major
      Found in homes/models.py - About 45 mins to fix

        Function resident_counts_by_activity_level has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def resident_counts_by_activity_level(self) -> dict[str, int]:
                """Returns a dictionary of counts of residents by activity level."""
         
                annotated_residents = self.residents_with_recent_activity_counts
         
         
        Severity: Minor
        Found in homes/models.py - About 25 mins to fix

        File not formatted according to black style guide
        Open

                return success_url
        Severity: Minor
        Found in homes/views.py by black

        File not formatted according to black style guide
        Open

                return super().form_valid(form)
        Severity: Minor
        Found in work/views.py by black

        Line length
        Open

        Remember, adhering to these guidelines not only helps in compliance with regulations like the GDPR but also builds trust with users and the broader community. As contributors, your commitment to these principles is invaluable in fostering a responsible and privacy-conscious software ecosystem.
        Severity: Info
        Found in CONTRIBUTING.md by markdownlint

        Ordered list item prefix
        Open

        9. **Documentation and Compliance:** Document data flows and privacy measures. While the software itself may not be directly subject to GDPR, good documentation practices help downstream users to achieve compliance.
        Severity: Info
        Found in CONTRIBUTING.md by markdownlint
        Severity
        Category
        Status
        Source
        Language