Sign upLogin

GetDKAN/dkan

View on GitHub
Star
modules/harvest/src/HarvestService.php

Summary

Maintainability
A
0 mins
Test Coverage
A
92%

HarvestService has 21 functions (exceeds 20 allowed). Consider refactoring.
Wontfix

class HarvestService implements ContainerInjectionInterface {

  use OrphanDatasetsProcessor;

  /**
Severity: Minor
Found in modules/harvest/src/HarvestService.php - About 2 hrs to fix

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Wontfix

        FactoryInterface $storeFactory,
    HarvestHashesDatabaseTableFactory $hashesStoreFactory,
    MetastoreService $metastore,
    HarvestPlanRepository $harvestPlansRepository,
    HarvestRunRepository $runRepository,
    Severity: Minor
    Found in modules/harvest/src/HarvestService.php - About 45 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Wontfix

        public function __construct(
    FactoryInterface $storeFactory,
    HarvestHashesDatabaseTableFactory $hashesStoreFactory,
    MetastoreService $metastore,
    HarvestPlanRepository $harvestPlansRepository,
      Severity: Major
      Found in modules/harvest/src/HarvestService.php and 2 other locations - About 1 hr to fix
      modules/datastore/src/DatastoreService.php on lines 93..107
      modules/harvest/src/HarvestUtility.php on lines 64..78

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status