Showing 11 of 13 total issues
Method recurring_options_for_select
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def recurring_options_for_select(currently_selected_rule = nil, default_schedules = nil, options = {})
options_array = []
blank_option_label = options[:blank_label] || I18n.t("recurring_select.not_recurring")
blank_option = [blank_option_label, "null"]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method filter_params
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def self.filter_params(params)
params.reject!{|key, value| value.blank? || value=="null" }
params[:interval] = params[:interval].to_i if params[:interval]
params[:week_start] = params[:week_start].to_i if params[:week_start]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function serialize
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
function serialize(params, prefix) {
const query = Object.keys(params).map((key) => {
const value = params[key];
if (params.constructor === Array)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method filter_params
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.filter_params(params)
params.reject!{|key, value| value.blank? || value=="null" }
params[:interval] = params[:interval].to_i if params[:interval]
params[:week_start] = params[:week_start].to_i if params[:week_start]
Method recurring_options_for_select
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def recurring_options_for_select(currently_selected_rule = nil, default_schedules = nil, options = {})
options_array = []
blank_option_label = options[:blank_label] || I18n.t("recurring_select.not_recurring")
blank_option = [blank_option_label, "null"]
Method initialize
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(object, method, template_object, default_schedules = nil, options = {}, html_options = {})
Method select_recurring
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def select_recurring(object, method, default_schedules = nil, options = {}, html_options = {})
Method dirty_hash_to_rule
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def self.dirty_hash_to_rule(params)
if params.is_a? IceCube::Rule
params
else
params = JSON.parse(params, quirks_mode: true) if params.is_a?(String)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return true if possible_rule.is_a?(Hash)
Method is_valid_rule?
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def self.is_valid_rule?(possible_rule)
return true if possible_rule.is_a?(IceCube::Rule)
return false if possible_rule.blank?
if possible_rule.is_a?(String)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method call
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def call(env)
regexp = /^\/recurring_select\/translate\/(.*)/
if env["PATH_INFO"] =~ regexp
I18n.locale = env["PATH_INFO"].scan(regexp).first.first
request = Rack::Request.new(env)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"