Sign upLogin

GladysProject/Gladys

View on GitHub
Star
front/src/components/boxs/weather/EditWeatherBox.jsx

Summary

Maintainability
C
1 day
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  getHouses = async () => {
    try {
      await this.setState({
        error: false,
        pending: true
Severity: Major
Found in front/src/components/boxs/weather/EditWeatherBox.jsx and 1 other location - About 4 hrs to fix
front/src/components/boxs/alarm/EditAlarm.jsx on lines 20..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 128.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        {props.houses &&
          props.houses.map(house => (
            <option selected={house.selector === props.box.house} value={house.selector}>
              {house.name}
            </option>
Severity: Major
Found in front/src/components/boxs/weather/EditWeatherBox.jsx and 2 other locations - About 2 hrs to fix
front/src/components/boxs/camera/EditCamera.jsx on lines 16..21
front/src/routes/integration/all/zwave/node-page/Device.jsx on lines 134..139

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

  updateBoxHouse = e => {
    this.props.updateBoxConfig(this.props.x, this.props.y, {
      house: e.target.value
    });
  };
Severity: Major
Found in front/src/components/boxs/weather/EditWeatherBox.jsx and 11 other locations - About 1 hr to fix
front/src/components/boxs/alarm/EditAlarm.jsx on lines 8..12
front/src/components/boxs/alarm/EditAlarm.jsx on lines 14..18
front/src/components/boxs/camera/EditCamera.jsx on lines 87..91
front/src/components/boxs/camera/EditCamera.jsx on lines 93..97
front/src/components/boxs/camera/EditCamera.jsx on lines 99..103
front/src/components/boxs/chart/EditChart.jsx on lines 108..110
front/src/components/boxs/clock/EditClock.jsx on lines 8..10
front/src/components/boxs/device-in-room/EditDevices.jsx on lines 19..23
front/src/components/boxs/room-humidity/EditRoomHumidityBox.jsx on lines 64..68
front/src/components/boxs/room-temperature/EditRoomTemperatureBox.jsx on lines 72..76
front/src/components/boxs/scene/EditSceneBox.jsx on lines 19..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status