Sign upLogin

GladysProject/Gladys

View on GitHub
Star
front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx

Summary

Maintainability
F
3 days
Test Coverage

Function render has 121 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render({ device, houses }, { loading }) {
    const manufacturer = device.params.find(param => param.name === PARAMS.MANUFACTURER);
    const macAddress = device.params.find(param => param.name === PARAMS.MAC);
    const orginalName = device.params.find(param => param.name === PARAMS.NAME);
Severity: Major
Found in front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    <div class="form-group">
                  <label class="form-label">
                    <Text id="editDeviceForm.roomLabel" />
                  </label>
                  <select onChange={this.updateRoom} class="form-control">
    Severity: Major
    Found in front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx and 1 other location - About 1 day to fix
    front/src/routes/integration/all/lan-manager/device-page/LANManagerDevice.jsx on lines 79..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 219.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      saveDevice = async () => {
    this.setState({ loading: true });
    try {
      await this.props.saveDevice(this.props.deviceIndex);
    } catch (e) {
    Severity: Major
    Found in front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx and 5 other locations - About 3 hrs to fix
    front/src/routes/integration/all/bluetooth/device-page/BluetoothDevice.jsx on lines 25..33
    front/src/routes/integration/all/lan-manager/device-page/LANManagerDevice.jsx on lines 11..19
    front/src/routes/integration/all/rtsp-camera/RtspCameraBox.jsx on lines 27..41
    front/src/routes/integration/all/xiaomi/Device.jsx on lines 35..43
    front/src/routes/integration/all/zwave/node-page/Device.jsx on lines 35..43

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 104.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    <div class="form-group">
                  <label class="form-label">
                    <Text id="integration.lanManager.device.originalNameLabel" />
                  </label>
                  <Localizer>
    Severity: Major
    Found in front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx and 2 other locations - About 3 hrs to fix
    front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx on lines 80..92
    front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx on lines 93..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    <div class="form-group">
                  <label class="form-label">
                    <Text id="integration.lanManager.device.ipAddressLabel" />
                  </label>
                  <Localizer>
    Severity: Major
    Found in front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx and 2 other locations - About 3 hrs to fix
    front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx on lines 80..92
    front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx on lines 109..121

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    <div class="form-group">
                  <label class="form-label">
                    <Text id="integration.lanManager.device.manufacturerLabel" />
                  </label>
                  <Localizer>
    Severity: Major
    Found in front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx and 2 other locations - About 3 hrs to fix
    front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx on lines 93..100
    front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx on lines 109..121

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                    <div class="form-group">
                  <label class="form-label">
                    <Text id="integration.lanManager.device.macAddressLabel" />
                  </label>
                  <Localizer>
    Severity: Major
    Found in front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx and 3 other locations - About 2 hrs to fix
    front/src/routes/integration/all/lan-manager/device-page/LANManagerDevice.jsx on lines 99..106
    front/src/routes/integration/all/lan-manager/device-page/LANManagerDevice.jsx on lines 107..114
    front/src/routes/integration/all/lan-manager/device-page/LANManagerDevice.jsx on lines 115..122

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status