Sign upLogin

GladysProject/Gladys

View on GitHub
Star
front/src/routes/integration/all/zwave/node-page/Device.jsx

Summary

Maintainability
F
3 days
Test Coverage

Function render has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render(props, { batteryLevel, mostRecentValueAt, loading, tooMuchStatesError, statesNumber }) {
    return (
      <div class="col-md-6">
        <div class="card">
          <div class="card-header">
Severity: Major
Found in front/src/routes/integration/all/zwave/node-page/Device.jsx - About 3 hrs to fix

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

      deleteDevice = async () => {
    this.setState({ loading: true, tooMuchStatesError: false, statesNumber: undefined });
    try {
      await this.props.deleteDevice(this.props.device, this.props.deviceIndex);
    } catch (e) {
    Severity: Major
    Found in front/src/routes/integration/all/zwave/node-page/Device.jsx and 5 other locations - About 1 day to fix
    front/src/routes/integration/all/bluetooth/device-page/BluetoothDevice.jsx on lines 34..49
    front/src/routes/integration/all/lan-manager/device-page/LANManagerDevice.jsx on lines 20..35
    front/src/routes/integration/all/mqtt/device-page/Device.jsx on lines 23..38
    front/src/routes/integration/all/philips-hue/device-page/Device.jsx on lines 19..34
    front/src/routes/integration/all/xiaomi/Device.jsx on lines 44..59

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 234.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    <div class="form-group">
                  <label>
                    <Text id="integration.zwave.device.nameLabel" />
                  </label>
                  <Localizer>
    Severity: Major
    Found in front/src/routes/integration/all/zwave/node-page/Device.jsx and 2 other locations - About 4 hrs to fix
    front/src/components/boxs/alarm/EditAlarm.jsx on lines 48..61
    front/src/routes/integration/all/rtsp-camera/RtspCameraBox.jsx on lines 106..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      saveDevice = async () => {
    this.setState({ loading: true });
    try {
      await this.props.saveDevice(this.props.device);
    } catch (e) {
    Severity: Major
    Found in front/src/routes/integration/all/zwave/node-page/Device.jsx and 5 other locations - About 3 hrs to fix
    front/src/routes/integration/all/bluetooth/device-page/BluetoothDevice.jsx on lines 25..33
    front/src/routes/integration/all/lan-manager/device-page/LANManagerDevice.jsx on lines 11..19
    front/src/routes/integration/all/lan-manager/discover-page/LANManagerDiscoverDevice.jsx on lines 11..19
    front/src/routes/integration/all/rtsp-camera/RtspCameraBox.jsx on lines 27..41
    front/src/routes/integration/all/xiaomi/Device.jsx on lines 35..43

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 104.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                    <div class="form-group">
                  <button onClick={this.deleteDevice} class="btn btn-danger mr-2">
                    <Text id="integration.zwave.device.deleteButton" />
                  </button>
                  <button onClick={this.convertDeviceToMqtt} class="btn btn-warning">
    Severity: Major
    Found in front/src/routes/integration/all/zwave/node-page/Device.jsx and 3 other locations - About 3 hrs to fix
    front/src/routes/integration/all/lan-manager/device-page/LANManagerDevice.jsx on lines 129..136
    front/src/routes/integration/all/philips-hue/device-page/Device.jsx on lines 56..63
    front/src/routes/integration/all/tp-link/device-page/Device.jsx on lines 64..71

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                              {house.rooms &&
                            house.rooms.map(room => (
                              <option selected={room.id === props.device.room_id} value={room.id}>
                                {room.name}
                              </option>
    Severity: Major
    Found in front/src/routes/integration/all/zwave/node-page/Device.jsx and 2 other locations - About 2 hrs to fix
    front/src/components/boxs/camera/EditCamera.jsx on lines 16..21
    front/src/components/boxs/weather/EditWeatherBox.jsx on lines 18..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        this.props.device.features.forEach(feature => {
      if (feature.last_value_changed && new Date(feature.last_value_changed) > mostRecentValueAt) {
        mostRecentValueAt = new Date(feature.last_value_changed);
      }
    });
    Severity: Major
    Found in front/src/routes/integration/all/zwave/node-page/Device.jsx and 1 other location - About 1 hr to fix
    front/src/routes/integration/all/mqtt/device-page/Device.jsx on lines 49..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status