Sign upLogin

GladysProject/Gladys

View on GitHub
Star
front/src/routes/scene/edit-scene/actions/HttpRequest.jsx

Summary

Maintainability
F
4 days
Test Coverage

Function render has 117 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render(props) {
    const displayBody = METHOD_WITH_BODY.includes(props.action.method);
    return (
      <div>
        <div
Severity: Major
Found in front/src/routes/scene/edit-scene/actions/HttpRequest.jsx - About 4 hrs to fix

    File HttpRequest.jsx has 310 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { Component } from 'preact';
import { connect } from 'unistore/preact';
import { Text, Localizer } from 'preact-i18n';
import cx from 'classnames';
import update from 'immutability-helper';
    Severity: Minor
    Found in front/src/routes/scene/edit-scene/actions/HttpRequest.jsx - About 3 hrs to fix

      Function render has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        render(props) {
    return (
      <div class="row g-2 mb-2">
        <div class="col-5">
          <Localizer>
      Severity: Minor
      Found in front/src/routes/scene/edit-scene/actions/HttpRequest.jsx - About 1 hr to fix

        Function getAllPropertiesObject has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        const getAllPropertiesObject = (obj, path = '', results = []) => {
  Object.keys(obj).forEach(key => {
    const value = obj[key];
    const shouldContinueParsingTree = typeof value === 'object' && value !== null && value !== undefined;
    const keyIsNumber = isNumeric(key);
        Severity: Minor
        Found in front/src/routes/scene/edit-scene/actions/HttpRequest.jsx - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        <div class="form-group">
                  <label class="form-label">
                    <Text id="editScene.actionsCard.httpRequest.bodyLabel" />
                  </label>
                  <div style={helpTextStyle}>
        Severity: Major
        Found in front/src/routes/scene/edit-scene/actions/HttpRequest.jsx and 1 other location - About 7 hrs to fix
        front/src/routes/scene/edit-scene/actions/SendMqttMessage.jsx on lines 42..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 179.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                      <div class="form-group">
                <label class="form-label">
                  <Text id="editScene.actionsCard.httpRequest.urlLabel" />
                  <span class="form-required">
                    <Text id="global.requiredField" />
        Severity: Major
        Found in front/src/routes/scene/edit-scene/actions/HttpRequest.jsx and 1 other location - About 5 hrs to fix
        front/src/routes/scene/edit-scene/actions/SendMqttMessage.jsx on lines 25..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 154.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                <div class="col-5">
          <Localizer>
            <input
              type="text"
              class="form-control"
        Severity: Major
        Found in front/src/routes/scene/edit-scene/actions/HttpRequest.jsx and 2 other locations - About 2 hrs to fix
        front/src/routes/scene/edit-scene/actions/DelayActionParams.jsx on lines 25..35
        front/src/routes/scene/edit-scene/actions/HttpRequest.jsx on lines 61..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                <div class="col-5">
          <Localizer>
            <input
              type="text"
              class="form-control"
        Severity: Major
        Found in front/src/routes/scene/edit-scene/actions/HttpRequest.jsx and 2 other locations - About 2 hrs to fix
        front/src/routes/scene/edit-scene/actions/DelayActionParams.jsx on lines 25..35
        front/src/routes/scene/edit-scene/actions/HttpRequest.jsx on lines 72..82

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          handleChangeBody = text => {
    const newBody = text && text.length > 0 ? text : undefined;
    this.props.updateActionProperty(this.props.columnIndex, this.props.index, 'body', newBody);
  };
        Severity: Major
        Found in front/src/routes/scene/edit-scene/actions/HttpRequest.jsx and 1 other location - About 1 hr to fix
        front/src/routes/scene/edit-scene/actions/SendMqttMessage.jsx on lines 16..19

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            if (!this.props.action.method) {
      this.props.updateActionProperty(this.props.columnIndex, this.props.index, 'method', 'post');
    }
        Severity: Major
        Found in front/src/routes/scene/edit-scene/actions/HttpRequest.jsx and 2 other locations - About 1 hr to fix
        front/src/routes/scene/edit-scene/actions/BlinkLightParams.jsx on lines 67..69
        front/src/routes/scene/edit-scene/actions/DelayActionParams.jsx on lines 14..16

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

          handleChangeUrl = e => {
    this.props.updateActionProperty(this.props.columnIndex, this.props.index, 'url', e.target.value);
  };
        Severity: Major
        Found in front/src/routes/scene/edit-scene/actions/HttpRequest.jsx and 10 other locations - About 55 mins to fix
        front/src/routes/integration/all/ewelink/EweLinkDeviceBox.jsx on lines 11..13
        front/src/routes/integration/all/ewelink/EweLinkDeviceBox.jsx on lines 15..17
        front/src/routes/scene/edit-scene/actions/BlinkLightParams.jsx on lines 42..44
        front/src/routes/scene/edit-scene/actions/CalendarIsEventRunning.jsx on lines 56..58
        front/src/routes/scene/edit-scene/actions/DelayActionParams.jsx on lines 10..12
        front/src/routes/scene/edit-scene/actions/EcowattCondition.jsx on lines 9..11
        front/src/routes/scene/edit-scene/actions/EdfTempoCondition.jsx on lines 9..11
        front/src/routes/scene/edit-scene/actions/EdfTempoCondition.jsx on lines 13..20
        front/src/routes/scene/edit-scene/actions/EdfTempoCondition.jsx on lines 22..29
        front/src/routes/scene/edit-scene/actions/SendMqttMessage.jsx on lines 13..15

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status