GladysProject/Gladys

View on GitHub

Showing 2,674 of 2,674 total issues

Function discover has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function discover() {
  if (!this.connected) {
    await this.connect();
  }

Severity: Minor
Found in server/services/ewelink/lib/device/discover.js - About 1 hr to fix

    Function loginTwoFactor has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function loginTwoFactor(twoFactorToken, twoFactorCode) {
      // We login with two factor code
      await this.gladysGatewayClient.loginInstance(twoFactorToken, twoFactorCode);
      // we get all variables
      const gladysGatewayRefreshToken = await this.variable.getValue('GLADYS_GATEWAY_REFRESH_TOKEN');
    Severity: Minor
    Found in server/lib/gateway/gateway.loginTwoFactor.js - About 1 hr to fix

      Function addFeature has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        addFeature() {
          const featureData = this.state.selectedFeature.split('|');
      
          let defaultValues = {};
      
      
      Severity: Minor
      Found in front/src/routes/integration/all/mqtt/device-page/setup/index.js - About 1 hr to fix

        Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          render({}, { houses }) {
            return (
              <div>
                {this.props.trigger.type === EVENTS.HOUSE.EMPTY && (
                  <p>
        Severity: Minor
        Found in front/src/routes/scene/edit-scene/triggers/HouseEmptyOrNot.jsx - About 1 hr to fix

          Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            render(props, { selectedOption, userOptions, houseOptions, selectedHouseOption }) {
              return (
                <div>
                  <p>
                    {props.action.type === ACTIONS.USER.SET_SEEN_AT_HOME && (
          Severity: Minor
          Found in front/src/routes/scene/edit-scene/actions/UserPresence.jsx - About 1 hr to fix

            Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              render(props, { userOptions, selectedOption, houseOptions, selectedHouseOption }) {
                return (
                  <div>
                    <p>
                      {props.trigger.type === EVENTS.USER_PRESENCE.BACK_HOME && (
            Severity: Minor
            Found in front/src/routes/scene/edit-scene/triggers/UserPresenceTrigger.jsx - About 1 hr to fix

              Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                render(props, { selectedDeviceFeature }) {
                  let binaryDevice = false;
                  let presenceDevice = false;
                  let buttonClickDevice = false;
              
              
              Severity: Minor
              Found in front/src/routes/scene/edit-scene/triggers/DeviceFeatureState.jsx - About 1 hr to fix

                Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  render(props, {}) {
                    const boxData = get(props, `${DASHBOARD_BOX_DATA_KEY}HumidityInRoom.${props.x}_${props.y}`);
                    const boxStatus = get(props, `${DASHBOARD_BOX_STATUS_KEY}HumidityInRoom.${props.x}_${props.y}`);
                    const humidity = get(boxData, 'room.humidity.humidity');
                    const unit = get(boxData, 'room.humidity.unit');
                Severity: Minor
                Found in front/src/components/boxs/room-humidity/RoomHumidity.jsx - About 1 hr to fix

                  Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    render(props, { userOptions, selectedOption, areaOptions, selectedAreaOption }) {
                      return (
                        <div>
                          <p>
                            {props.trigger.type === EVENTS.AREA.USER_ENTERED && (

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                          const deviceFeature = await db.DeviceFeature.findOne({
                            where: {
                              device_id: enedisDevice.id,
                              category: DEVICE_FEATURE_CATEGORIES.ENERGY_SENSOR,
                              type: DEVICE_FEATURE_TYPES.ENERGY_SENSOR.DAILY_CONSUMPTION,
                    Severity: Major
                    Found in server/migrations/20230518062954-enedis-reset-aggregate.js and 2 other locations - About 1 hr to fix
                    server/migrations/20230414020652-enedis-unit-is-watt-hour.js on lines 24..30
                    server/migrations/20230428064822-translate-enedis-name.js on lines 43..49

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                          const deviceFeature = await db.DeviceFeature.findOne({
                            where: {
                              device_id: enedisDevice.id,
                              category: DEVICE_FEATURE_CATEGORIES.ENERGY_SENSOR,
                              type: DEVICE_FEATURE_TYPES.ENERGY_SENSOR.DAILY_CONSUMPTION,
                    server/migrations/20230428064822-translate-enedis-name.js on lines 43..49
                    server/migrations/20230518062954-enedis-reset-aggregate.js on lines 24..30

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 8 locations. Consider refactoring.
                    Open

                        updateDeviceProperty(state, index, property, value) {
                          const newState = update(state, {
                            xiaomiDevices: {
                              [index]: {
                                [property]: {
                    Severity: Major
                    Found in front/src/routes/integration/all/xiaomi/actions.js and 7 other locations - About 1 hr to fix
                    front/src/routes/integration/all/bluetooth/device-page/actions.js on lines 35..46
                    front/src/routes/integration/all/lan-manager/device-page/actions.js on lines 50..61
                    front/src/routes/integration/all/lan-manager/discover-page/actions.js on lines 115..126
                    front/src/routes/integration/all/mqtt/device-page/actions.js on lines 44..55
                    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 86..97
                    front/src/routes/integration/all/tp-link/device-page/actions.js on lines 84..95
                    front/src/routes/integration/all/zwave/node-page/actions.js on lines 34..45

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 8 locations. Consider refactoring.
                    Open

                        updateDeviceProperty(state, index, property, value) {
                          const newState = update(state, {
                            lanManagerDiscoveredDevices: {
                              [index]: {
                                [property]: {
                    front/src/routes/integration/all/bluetooth/device-page/actions.js on lines 35..46
                    front/src/routes/integration/all/lan-manager/device-page/actions.js on lines 50..61
                    front/src/routes/integration/all/mqtt/device-page/actions.js on lines 44..55
                    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 86..97
                    front/src/routes/integration/all/tp-link/device-page/actions.js on lines 84..95
                    front/src/routes/integration/all/xiaomi/actions.js on lines 86..97
                    front/src/routes/integration/all/zwave/node-page/actions.js on lines 34..45

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 8 locations. Consider refactoring.
                    Open

                        updateDeviceProperty(state, index, property, value) {
                          const newState = update(state, {
                            tpLinkDevices: {
                              [index]: {
                                [property]: {
                    front/src/routes/integration/all/bluetooth/device-page/actions.js on lines 35..46
                    front/src/routes/integration/all/lan-manager/device-page/actions.js on lines 50..61
                    front/src/routes/integration/all/lan-manager/discover-page/actions.js on lines 115..126
                    front/src/routes/integration/all/mqtt/device-page/actions.js on lines 44..55
                    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 86..97
                    front/src/routes/integration/all/xiaomi/actions.js on lines 86..97
                    front/src/routes/integration/all/zwave/node-page/actions.js on lines 34..45

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 8 locations. Consider refactoring.
                    Open

                      async function update(req, res) {
                        const house = await gladys.house.update(req.params.house_selector, req.body);
                        res.json(house);
                      }
                    Severity: Major
                    Found in server/api/controllers/house.controller.js and 7 other locations - About 1 hr to fix
                    server/api/controllers/area.controller.js on lines 55..58
                    server/api/controllers/calendar.controller.js on lines 68..71
                    server/api/controllers/calendar.controller.js on lines 126..129
                    server/api/controllers/room.controller.js on lines 45..48
                    server/api/controllers/scene.controller.js on lines 34..37
                    server/api/controllers/session.controller.js on lines 34..37
                    server/api/controllers/user.controller.js on lines 88..91

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 8 locations. Consider refactoring.
                    Open

                        updateDeviceProperty(state, index, property, value) {
                          const newState = update(state, {
                            mqttDevices: {
                              [index]: {
                                [property]: {
                    front/src/routes/integration/all/bluetooth/device-page/actions.js on lines 35..46
                    front/src/routes/integration/all/lan-manager/device-page/actions.js on lines 50..61
                    front/src/routes/integration/all/lan-manager/discover-page/actions.js on lines 115..126
                    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 86..97
                    front/src/routes/integration/all/tp-link/device-page/actions.js on lines 84..95
                    front/src/routes/integration/all/xiaomi/actions.js on lines 86..97
                    front/src/routes/integration/all/zwave/node-page/actions.js on lines 34..45

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 8 locations. Consider refactoring.
                    Open

                      async function update(req, res) {
                        const area = await gladys.area.update(req.params.area_selector, req.body);
                        res.json(area);
                      }
                    Severity: Major
                    Found in server/api/controllers/area.controller.js and 7 other locations - About 1 hr to fix
                    server/api/controllers/calendar.controller.js on lines 68..71
                    server/api/controllers/calendar.controller.js on lines 126..129
                    server/api/controllers/house.controller.js on lines 82..85
                    server/api/controllers/room.controller.js on lines 45..48
                    server/api/controllers/scene.controller.js on lines 34..37
                    server/api/controllers/session.controller.js on lines 34..37
                    server/api/controllers/user.controller.js on lines 88..91

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 8 locations. Consider refactoring.
                    Open

                      async function getTabletMode(req, res) {
                        const session = await gladys.session.getTabletMode(req.user.id, req.session_id);
                        res.json(session);
                      }
                    Severity: Major
                    Found in server/api/controllers/session.controller.js and 7 other locations - About 1 hr to fix
                    server/api/controllers/area.controller.js on lines 55..58
                    server/api/controllers/calendar.controller.js on lines 68..71
                    server/api/controllers/calendar.controller.js on lines 126..129
                    server/api/controllers/house.controller.js on lines 82..85
                    server/api/controllers/room.controller.js on lines 45..48
                    server/api/controllers/scene.controller.js on lines 34..37
                    server/api/controllers/user.controller.js on lines 88..91

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                          const deviceFeature = await db.DeviceFeature.findOne({
                            where: {
                              device_id: enedisDevice.id,
                              category: DEVICE_FEATURE_CATEGORIES.ENERGY_SENSOR,
                              type: DEVICE_FEATURE_TYPES.ENERGY_SENSOR.DAILY_CONSUMPTION,
                    Severity: Major
                    Found in server/migrations/20230428064822-translate-enedis-name.js and 2 other locations - About 1 hr to fix
                    server/migrations/20230414020652-enedis-unit-is-watt-hour.js on lines 24..30
                    server/migrations/20230518062954-enedis-reset-aggregate.js on lines 24..30

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 8 locations. Consider refactoring.
                    Open

                        updateDeviceProperty(state, index, property, value) {
                          const newState = update(state, {
                            lanManagerDevices: {
                              [index]: {
                                [property]: {
                    front/src/routes/integration/all/bluetooth/device-page/actions.js on lines 35..46
                    front/src/routes/integration/all/lan-manager/discover-page/actions.js on lines 115..126
                    front/src/routes/integration/all/mqtt/device-page/actions.js on lines 44..55
                    front/src/routes/integration/all/philips-hue/device-page/actions.js on lines 86..97
                    front/src/routes/integration/all/tp-link/device-page/actions.js on lines 84..95
                    front/src/routes/integration/all/xiaomi/actions.js on lines 86..97
                    front/src/routes/integration/all/zwave/node-page/actions.js on lines 34..45

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language