Sign upLogin

Glavin001/graphql-sequelize-crud

View on GitHub
Star
src/getSchema.ts

Summary

Maintainability
D
2 days
Test Coverage

Function getSchema has 212 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function getSchema(sequelize: Sequelize) {

    const { nodeInterface, nodeField, nodeTypeMapper } = sequelizeNodeInterface(sequelize);

    const models: Models = sequelize.models as any;
Severity: Major
Found in src/getSchema.ts - About 1 day to fix

    Function modelTypes has 81 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const modelTypes: ModelTypes = Object.keys(models).reduce((types: ModelTypes, key: string) => {
        const model: Model = models[key];
        const modelType = new GraphQLObjectType({
            name: getTableName(model),
            fields: () => {
    Severity: Major
    Found in src/getSchema.ts - About 3 hrs to fix

      File getSchema.ts has 251 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // tslint:disable-next-line:no-reference
/// <reference path="./@types/graphql-sequelize/index.d.ts" />

import {
    GraphQLObjectType,
      Severity: Minor
      Found in src/getSchema.ts - About 2 hrs to fix

        Function fields has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    fields: () => {
                // Attribute fields
                const defaultFields = attributeFields(model, {
                    exclude: model.excludeFields ? model.excludeFields : [],
                    globalId: true,
        Severity: Minor
        Found in src/getSchema.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              edgeFields = attributeFields(aModel, {
                        exclude: aModel.excludeFields ? aModel.excludeFields : [],
                        globalId: true,
                        commentToDescription: true,
                        cache
          Severity: Minor
          Found in src/getSchema.ts and 1 other location - About 55 mins to fix
          src/getSchema.ts on lines 63..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          const defaultFields = attributeFields(model, {
                    exclude: model.excludeFields ? model.excludeFields : [],
                    globalId: true,
                    commentToDescription: true,
                    cache
          Severity: Minor
          Found in src/getSchema.ts and 1 other location - About 55 mins to fix
          src/getSchema.ts on lines 190..195

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status