Sign upLogin

GlobalNamesArchitecture/dwca-hunter

View on GitHub
Star
lib/dwca_hunter/resources/itis.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method generate_dwca has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def generate_dwca
      DwcaHunter.logger_write(object_id,
                              "Creating DarwinCore Archive file")
      @core = [["http://rs.tdwg.org/dwc/terms/taxonID",
                "http://rs.tdwg.org/dwc/terms/parentNameUsageID",
Severity: Major
Found in lib/dwca_hunter/resources/itis.rb - About 2 hrs to fix

    Method get_names has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def get_names
      # 0    tsn serial not null
      # 1    unit_ind1 char(1)
      # 2    unit_name1 char(35) not null
      # 3    unit_ind2 char(1)
    Severity: Minor
    Found in lib/dwca_hunter/resources/itis.rb - About 1 hr to fix

      Method get_names has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_names
      # 0    tsn serial not null
      # 1    unit_ind1 char(1)
      # 2    unit_name1 char(35) not null
      # 3    unit_ind2 char(1)
      Severity: Minor
      Found in lib/dwca_hunter/resources/itis.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status