Sign upLogin

GlobalNamesArchitecture/dwca-hunter

View on GitHub
Star
lib/dwca_hunter/resources/ncbi.rb

Summary

Maintainability
C
1 day
Test Coverage

Method get_classification has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    def get_classification
      DwcaHunter.logger_write(object_id, "Building classification...")
      open(@nodes_file, "r:utf-8").each_with_index do |line, i|
        DwcaHunter.logger_write(object_id, "Collected %s nodes..." % i) if i > 0 && i % BATCH_SIZE == 0
        line = line.split("|").map { |l| cleanup(l) }
Severity: Minor
Found in lib/dwca_hunter/resources/ncbi.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate_dwca has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def generate_dwca
      DwcaHunter.logger_write(object_id, "Creating DarwinCore Archive file")
      @core = [["http://rs.tdwg.org/dwc/terms/taxonId",
                "http://purl.org/dc/terms/scientificName",
                "http://purl.org/dc/terms/parentNameUsageId",
Severity: Major
Found in lib/dwca_hunter/resources/ncbi.rb - About 2 hrs to fix

    Method get_names has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_names
      DwcaHunter.logger_write(object_id, "Collecting names...")
      open(@names_file).each_with_index do |line, i|
        DwcaHunter.logger_write(object_id, "Collected %s names..." % i) if i > 0 && i % BATCH_SIZE == 0
        line = line.split("|").map { |l| cleanup(l) }
    Severity: Minor
    Found in lib/dwca_hunter/resources/ncbi.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_classification has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def get_classification
      DwcaHunter.logger_write(object_id, "Building classification...")
      open(@nodes_file, "r:utf-8").each_with_index do |line, i|
        DwcaHunter.logger_write(object_id, "Collected %s nodes..." % i) if i > 0 && i % BATCH_SIZE == 0
        line = line.split("|").map { |l| cleanup(l) }
    Severity: Minor
    Found in lib/dwca_hunter/resources/ncbi.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status