Showing 691 of 691 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
minors = {-7: "Aflat", -6: "Eflat", -5: "Bflat", -4: "F", -3: "C", -2: "G", -1: "D",
0: "A", 1: "E", 2: "B", 3: "Fsharp", 4: "Csharp", 5: "Gsharp", 6: "Dsharp", 7: "Asharp"}- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 37.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Consider simplifying this complex logical expression. Open
if tag[-
2] == "technical" and tag[-
1] != "bend" and tag[-
1] != "hammer-on" and tag[-
1] != "pull-off":Function handleArticulation has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def handleArticulation(tag, attrs, content, piece, data):Function HandleMovementBetweenDurations has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def HandleMovementBetweenDurations(tags, attrs, chars, piece, data):Function handleOtherNotations has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def handleOtherNotations(tag, attrs, content, piece, data):Function HandleArpeggiates has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def HandleArpeggiates(tags, attrs, content, piece, data):Function HandleRepeatMarking has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def HandleRepeatMarking(tags, attrs, chars, piece, data):Function Search has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def Search(cls_type, node, index, depth=0, start_index=0):Function BackwardSearch has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def BackwardSearch(cls_type, node, index, depth=0, start_index=0):Function HandleFermata has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def HandleFermata(tags, attrs, chars, piece, data):Function HandleSlidesAndGliss has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def HandleSlidesAndGliss(tags, attrs, content, piece, data):Function handleLyrics has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def handleLyrics(tags, attrs, chars, piece, data):Function handleTimeMod has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def handleTimeMod(tags, attrs, chars, piece, data):Function HandleMeasures has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def HandleMeasures(tag, attrib, content, piece, data):Function handleBarline has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def handleBarline(tag, attrib, content, piece, data):Function handleOrnaments has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def handleOrnaments(tags, attrs, content, piece, data):Function HandlePitch has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def HandlePitch(tags, attrs, text, piece, data):Function handleClef has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def handleClef(tag, attrib, content, piece, data):Function CreateNote has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def CreateNote(tag, attrs, content, piece, data):Function HandleDirections has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def HandleDirections(tags, attrs, chars, piece, data):