Sign upLogin

Godley/Music-Library

View on GitHub
Star
Application.py

Summary

Maintainability
C
1 day
Test Coverage

Application has 35 functions (exceeds 20 allowed). Consider refactoring.
Open

class Application(QtCore.QObject):
    windows = {}

    def __init__(self, app):
        self.wifi = True
Severity: Minor
Found in Application.py - About 4 hrs to fix

    File Application.py has 312 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    from threading import Lock
import os
import pickle
from PyQt4 import QtGui, QtCore, QtXml
from implementation.primaries.GUI import renderingErrorPopup, SetupWindow
    Severity: Minor
    Found in Application.py - About 3 hrs to fix

      Function LoadMeta has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          def LoadMeta(self):
        try:
            col_fob = open(self.meta_file(), 'rb')
        except:
            self.SaveMeta()
      Severity: Minor
      Found in Application.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Cyclomatic complexity is too high in method LoadMeta. (9)
      Open

          def LoadMeta(self):
        try:
            col_fob = open(self.meta_file(), 'rb')
        except:
            self.SaveMeta()
      Severity: Minor
      Found in Application.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Avoid deeply nested control flow statements.
      Open

                              if os.path.exists(item):
                            self.meta["collections"].append(item)
            if "path" in result_temp:
      Severity: Major
      Found in Application.py - About 45 mins to fix

        Do not use bare 'except'
        Open

                except:
        Severity: Minor
        Found in Application.py by pep8

        When catching exceptions, mention specific exceptions when possible.

        Okay: except Exception:
Okay: except BaseException:
E722: except:

        'async' and 'await' are reserved keywords starting with python 3.7
        Open

                async.run()
        Severity: Minor
        Found in Application.py by pep8

        'async' and 'await' are reserved keywords starting at Python 3.7.

        W606: async = 42
W606: await = 42
Okay: async def read(db):
data = await db.fetch('SELECT ...')

        'async' and 'await' are reserved keywords starting with python 3.7
        Open

                QtCore.QObject.connect(async,
        Severity: Minor
        Found in Application.py by pep8

        'async' and 'await' are reserved keywords starting at Python 3.7.

        W606: async = 42
W606: await = 42
Okay: async def read(db):
data = await db.fetch('SELECT ...')

        Expected 2 blank lines after class or function definition, found 1
        Open

        if __name__ == '__main__':
        Severity: Minor
        Found in Application.py by pep8

        Separate top-level function and class definitions with two blank lines.

        Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

        'async' and 'await' are reserved keywords starting with python 3.7
        Open

                QtCore.QObject.connect(async,
        Severity: Minor
        Found in Application.py by pep8

        'async' and 'await' are reserved keywords starting at Python 3.7.

        W606: async = 42
W606: await = 42
Okay: async def read(db):
data = await db.fetch('SELECT ...')

        'async' and 'await' are reserved keywords starting with python 3.7
        Open

                async = qt_threading.DownloadThread(self, self.manager.downloadFile,
        Severity: Minor
        Found in Application.py by pep8

        'async' and 'await' are reserved keywords starting at Python 3.7.

        W606: async = 42
W606: await = 42
Okay: async def read(db):
data = await db.fetch('SELECT ...')

        'async' and 'await' are reserved keywords starting with python 3.7
        Open

                async = qt_threading.mythread(
        Severity: Minor
        Found in Application.py by pep8

        'async' and 'await' are reserved keywords starting at Python 3.7.

        W606: async = 42
W606: await = 42
Okay: async def read(db):
data = await db.fetch('SELECT ...')

        'async' and 'await' are reserved keywords starting with python 3.7
        Open

                async.run()
        Severity: Minor
        Found in Application.py by pep8

        'async' and 'await' are reserved keywords starting at Python 3.7.

        W606: async = 42
W606: await = 42
Okay: async def read(db):
data = await db.fetch('SELECT ...')

        'async' and 'await' are reserved keywords starting with python 3.7
        Open

                    async, QtCore.SIGNAL("dataReady(PyQt_PyObject)"), slot)
        Severity: Minor
        Found in Application.py by pep8

        'async' and 'await' are reserved keywords starting at Python 3.7.

        W606: async = 42
W606: await = 42
Okay: async def read(db):
data = await db.fetch('SELECT ...')

        There are no issues that match your filters.

        Category
        Status