Sign upLogin

Godley/Music-Library

View on GitHub
Star
implementation/primaries/GUI/MainWindow.py

Summary

Maintainability
D
2 days
Test Coverage

File MainWindow.py has 428 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from PyQt4 import QtGui, QtCore, uic
import sip
import os
import difflib
import time
Severity: Minor
Found in implementation/primaries/GUI/MainWindow.py - About 6 hrs to fix

    MainWindow has 33 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class MainWindow(QtGui.QMainWindow, themedWindow.ThemedWindow):
    widgets = {}
    frames = {}
    colors = {}
    Severity: Minor
    Found in implementation/primaries/GUI/MainWindow.py - About 4 hrs to fix

      Function setup_data_items has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          def setup_data_items(
            self,
            playlist_fnames,
            playlist_data,
            start_index,
      Severity: Minor
      Found in implementation/primaries/GUI/MainWindow.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function load has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def load(self):
        file = os.path.join(self.design_folder, "MainWindow.ui")
        uic.loadUi(file, self)
        self.setGeometry(0, 0, self.width(), self.height())
        self.widgets["scorebook"] = Widgets.Scorebook
      Severity: Major
      Found in implementation/primaries/GUI/MainWindow.py - About 2 hrs to fix

        Cyclomatic complexity is too high in method setup_data_items. (6)
        Open

            def setup_data_items(
            self,
            playlist_fnames,
            playlist_data,
            start_index,
        Severity: Minor
        Found in implementation/primaries/GUI/MainWindow.py by radon

        Cyclomatic Complexity

        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

        Construct Effect on CC Reasoning
        if +1 An if statement is a single decision.
        elif +1 The elif statement adds another decision.
        else +0 The else statement does not cause a new decision. The decision is at the if.
        for +1 There is a decision at the start of the loop.
        while +1 There is a decision at the while statement.
        except +1 Each except branch adds a new conditional path of execution.
        finally +0 The finally block is unconditionally executed.
        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
        assert +1 The assert statement internally roughly equals a conditional statement.
        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

        Source: http://radon.readthedocs.org/en/latest/intro.html

        Function loadFrame has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def loadFrame(self, child, ypos=72):
        """
        method which fetches the appropriate widget, puts it in the
        content frame and starts an animation to pull the frame out
        :param child: the name of the widget to load
        Severity: Minor
        Found in implementation/primaries/GUI/MainWindow.py - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                  if isinstance(value, list):
                            value = ", ".join(file[key])
                    item = QtGui.QTableWidgetItem(value)
          Severity: Major
          Found in implementation/primaries/GUI/MainWindow.py - About 45 mins to fix

            Function cleanupContentLayout has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def cleanupContentLayout(self, layout):
        if layout is not None:
            while layout.count():
                item = layout.takeAt(0)
                widge = item.widget()
            Severity: Minor
            Found in implementation/primaries/GUI/MainWindow.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Line too long (155 > 79 characters)
            Open

            from implementation.primaries.GUI.helpers import get_base_dir, parseStyle, postProcessLines, merge_instruments, merge_clefs_and_keys, fit_columns_to_widget
            Severity: Minor
            Found in implementation/primaries/GUI/MainWindow.py by pep8

            Limit all lines to a maximum of 79 characters.

            There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

            Do not use bare 'except'
            Open

                        except:
            Severity: Minor
            Found in implementation/primaries/GUI/MainWindow.py by pep8

            When catching exceptions, mention specific exceptions when possible.

            Okay: except Exception:
Okay: except BaseException:
E722: except:

            Line too long (105 > 79 characters)
            Open

            from implementation.primaries.GUI import themedWindow, Widgets, qt_threading, MultistandWidget, pdfViewer
            Severity: Minor
            Found in implementation/primaries/GUI/MainWindow.py by pep8

            Limit all lines to a maximum of 79 characters.

            There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

            Line too long (96 > 79 characters)
            Open

                    callback which is called when the parent application has finished working on an xml file
            Severity: Minor
            Found in implementation/primaries/GUI/MainWindow.py by pep8

            Limit all lines to a maximum of 79 characters.

            There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

            There are no issues that match your filters.

            Category
            Status