app/models/item_alexa_presenter.rb
Method item_description has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def item_description
result = "<speak>"
if intent == INTENTS[:stop]
result << "<p>Happy listening!</p>"
elsif item- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Put a comma after the last item of a multiline hash. Open
Open
text: 'Welcome to The Record Collection! You can ask me "what I should listen to" or for a specific format with "ask the record collection for a 12 inch record."'- Read upRead up
- Exclude checks
This cop checks for trailing comma in array and hash literals.
Example: EnforcedStyleForMultiline: consistent_comma
# bad
a = [1, 2,]
# good
a = [
1, 2,
3,
]
# good
a = [
1,
2,
]Example: EnforcedStyleForMultiline: comma
# bad
a = [1, 2,]
# good
a = [
1,
2,
]Example: EnforcedStyleForMultiline: no_comma (default)
# bad
a = [1, 2,]
# good
a = [
1,
2
]