Sign upLogin

GrafiteInc/Commerce

View on GitHub
Star

Showing 99 of 99 total issues

Function balanceValues has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function balanceValues($transactions)
    {
        $collected = $transactions->groupBy(function ($item) {
            return $item->created_at->format('d-M-y');
        });
Severity: Minor
Found in src/Services/AnalyticsService.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  function createLinkElement(options) {
    var linkElement = document.createElement("link");
    linkElement.rel = "stylesheet";
    insertStyleElement(options, linkElement);
    return linkElement;
Severity: Minor
Found in src/Publishes/public/js/card.js and 1 other location - About 35 mins to fix
src/Publishes/public/js/card.js on lines 672..677

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  function createStyleElement(options) {
    var styleElement = document.createElement("style");
    styleElement.type = "text/css";
    insertStyleElement(options, styleElement);
    return styleElement;
Severity: Minor
Found in src/Publishes/public/js/card.js and 1 other location - About 35 mins to fix
src/Publishes/public/js/card.js on lines 679..684

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    $('#deleteCouponForm').submit(function(e){
        e.preventDefault();
        $('#deleteCouponDialog').modal('show');
    });
Severity: Minor
Found in src/Assets/js/coupons.js and 1 other location - About 35 mins to fix
src/Assets/js/plans.js on lines 38..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    $('#deletePlanForm').submit(function(e){
        e.preventDefault();
        $('#deletePlanDialog').modal('show');
    });
Severity: Minor
Found in src/Assets/js/plans.js and 1 other location - About 35 mins to fix
src/Assets/js/coupons.js on lines 4..7

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

      return value.prototype === other.prototype;
Severity: Major
Found in src/Publishes/public/js/card.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return QJ.val(target, value.replace(/\s\d?$/, ''));
    Severity: Major
    Found in src/Publishes/public/js/card.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return false;
      Severity: Major
      Found in src/Publishes/public/js/card.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return true;
        Severity: Major
        Found in src/Publishes/public/js/card.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                    return expiry > currentTime;
          Severity: Major
          Found in src/Publishes/public/js/card.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return true;
            Severity: Major
            Found in src/Publishes/public/js/card.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return QJ.val(target, value.replace(/\s\/\s?\d?$/, ''));
              Severity: Major
              Found in src/Publishes/public/js/card.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return false;
                Severity: Major
                Found in src/Publishes/public/js/card.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return value.getTime() === other.getTime();
                  Severity: Major
                  Found in src/Publishes/public/js/card.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                              return false;
                    Severity: Major
                    Found in src/Publishes/public/js/card.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return QJ.trigger(target, 'change');
                      Severity: Major
                      Found in src/Publishes/public/js/card.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return e.preventDefault();
                        Severity: Major
                        Found in src/Publishes/public/js/card.js - About 30 mins to fix

                          Function invite has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function invite($admin, $id, $email)
    {
        try {
            if ($admin->isTeamAdmin($id)) {
                $user = $this->userService->findByEmail($email);
                          Severity: Minor
                          Found in fixture/Services/TeamService.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function create($payload)
    {
        try {
            $payload['stripe_id'] = $payload['code'];
            $payload['currency'] = config('commerce.currency');
                          Severity: Minor
                          Found in src/Services/CouponService.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language