Sign upLogin

GrafiteInc/FormMaker

View on GitHub
Star
src/Builders/FieldBuilder.php

Summary

Maintainability
D
2 days
Test Coverage

Function makeSelect has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    public function makeSelect($name, $selected, $options)
    {
        $selectOptions = '';

        if (isset($options['attributes']['value'])) {
Severity: Minor
Found in src/Builders/FieldBuilder.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File FieldBuilder.php has 297 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Grafite\Forms\Builders;

use DateTime;
Severity: Minor
Found in src/Builders/FieldBuilder.php - About 3 hrs to fix

    Method makeSelect has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function makeSelect($name, $selected, $options)
    {
        $selectOptions = '';

        if (isset($options['attributes']['value'])) {
    Severity: Major
    Found in src/Builders/FieldBuilder.php - About 2 hrs to fix

      Method makeCheckInput has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function makeCheckInput($name, $value, $options)
    {
        $customClasses = $options['attributes']['class'] ?? '';
        $customLabelClasses = $options['label_class'] ?? '';
      Severity: Minor
      Found in src/Builders/FieldBuilder.php - About 1 hr to fix

        Function makeCheckInput has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            public function makeCheckInput($name, $value, $options)
    {
        $customClasses = $options['attributes']['class'] ?? '';
        $customLabelClasses = $options['label_class'] ?? '';
        Severity: Minor
        Found in src/Builders/FieldBuilder.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method makeRelationship has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function makeRelationship($name, $value, $options)
    {
        $method = 'all';
        $class = $options['model'];
        Severity: Minor
        Found in src/Builders/FieldBuilder.php - About 1 hr to fix

          Function getOptionSelectedValue has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getOptionSelectedValue($selected, $value, $options)
    {
        $selectedValue = '';

        if (
          Severity: Minor
          Found in src/Builders/FieldBuilder.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function makeRelationship has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function makeRelationship($name, $value, $options)
    {
        $method = 'all';
        $class = $options['model'];
          Severity: Minor
          Found in src/Builders/FieldBuilder.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function isChecked has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function isChecked($name, $value, $options)
    {
        if (is_null($value) && isset($options['attributes']['value'])) {
            $value = $options['attributes']['value'];
        }
          Severity: Minor
          Found in src/Builders/FieldBuilder.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return '';
          Severity: Major
          Found in src/Builders/FieldBuilder.php - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function makeCheckbox($name, $value, $options)
    {
        $checked = $this->isChecked($name, $value, $options);
        $attributes = $this->attributeBuilder->render($options['attributes'], $name, $this->withLivewire, $this->livewireOnKeydown, $this->livewireOnChange);
            Severity: Minor
            Found in src/Builders/FieldBuilder.php and 1 other location - About 55 mins to fix
            src/Builders/FieldBuilder.php on lines 395..401

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function makeRadio($name, $value, $options)
    {
        $checked = $this->isChecked($name, $value, $options);
        $attributes = $this->attributeBuilder->render($options['attributes'], $name, $this->withLivewire, $this->livewireOnKeydown, $this->livewireOnChange);
            Severity: Minor
            Found in src/Builders/FieldBuilder.php and 1 other location - About 55 mins to fix
            src/Builders/FieldBuilder.php on lines 378..384

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 99.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status