Showing 48 of 48 total issues
File WeatherModelTrait.php
has 302 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Showing off a standard class with methods and properties.
*/
namespace Erjh17\CallUrlModel;
Function fetchGeoInfo
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
public function fetchGeoInfo()
{
$cUrl = $this->di->get("callurl");
$this->validateIp();
if (!$this->isValidIp() && $this->isCoord($this->ipAddress)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method fetchGeoInfo
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function fetchGeoInfo()
{
$cUrl = $this->di->get("callurl");
$this->validateIp();
if (!$this->isValidIp() && $this->isCoord($this->ipAddress)) {
Function fetchWeatherInfo
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
public function fetchWeatherInfo()
{
if ($this->latitude && $this->latitude) {
$cUrl = $this->di->get("callurl");
$args = $this->buildArgs();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method fetchConcurrently
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function fetchConcurrently($urls, $params, $queries)
{
$cache = $this->di->get("cache");
$hour = date('YMDH');
$latLonDay = explode(",", $params[0][1]);
Method fetchWeatherInfo
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function fetchWeatherInfo()
{
if ($this->latitude && $this->latitude) {
$cUrl = $this->di->get("callurl");
$args = $this->buildArgs();
Method buildArgs
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function buildArgs()
{
$time = $this->calculateTimeMachine();
$urls = array($this->darkSkyUrl);
Avoid using undefined variables such as '$running' which will lead to PHP notices. Open
} while ($running > 0);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$running' which will lead to PHP notices. Open
curl_multi_exec($master, $running);
- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}
Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Method hourly
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function hourly()
{
$hourly = [];
if ($this->hourly && isset($this->hourly["data"])) {
$this->hourly["data"] = array_slice($this->hourly["data"], 0, 12);
Method currently
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function currently()
{
$currently = [];
setlocale(LC_ALL, 'sv_SV');
if ($this->currently && $this->currently["time"]) {
Method pastDays
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function pastDays()
{
$pastDays = [];
if ($this->pastDays["data"]) {
Avoid variables with short names like $db. Configured minimum length is 3. Open
private $db = "not active";
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $i. Configured minimum length is 3. Open
public function parseDate($arr, $i, $time)
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $db. Configured minimum length is 3. Open
private $db = "not active";
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $db. Configured minimum length is 3. Open
private $db = "not active";
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Function fetchConcurrently
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function fetchConcurrently($urls, $params, $queries)
{
$cache = $this->di->get("cache");
$hour = date('YMDH');
$latLonDay = explode(",", $params[0][1]);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function validateIp
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function validateIp()
{
if ($this->ipAddress) {
if (filter_var($this->ipAddress, FILTER_VALIDATE_IP)) {
$this->valid = true;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function hourly
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function hourly()
{
$hourly = [];
if ($this->hourly && isset($this->hourly["data"])) {
$this->hourly["data"] = array_slice($this->hourly["data"], 0, 12);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function geoJsonActionPost() : array
{
$request = $this->di->get("request");
$client = $request->getServer('REMOTE_ADDR');
$ipaddress = $request->getPost("ip") ? $request->getPost("ip") : $client;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 91.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76