Sign upLogin

H-PixelDroid/PixelDroid

View on GitHub
Star
app/src/main/java/org/pixeldroid/app/LoginActivity.kt

Summary

Maintainability
D
1 day
Test Coverage

Method nodeInfoSchema has a Cognitive Complexity of 46 (exceeds 20 allowed). Consider refactoring.
Open

    private suspend fun nodeInfoSchema(
        normalizedDomain: String,
        clientId: String,
        nodeInfoSchemaUrl: String
    ) = coroutineScope {
Severity: Minor
Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File LoginActivity.kt has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package org.pixeldroid.app

import android.content.Context
import android.content.Intent
import android.content.SharedPreferences
Severity: Minor
Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt - About 2 hrs to fix

    Method authenticate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private fun authenticate(code: String?) {

        // Get previous values from preferences
        val domain = preferences.getString("domain", "") as String
        val clientId = preferences.getString("clientID", "") as String
    Severity: Minor
    Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt - About 1 hr to fix

      Method registerAppToServer has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private fun registerAppToServer(normalizedDomain: String) {

        if(!validDomain(normalizedDomain)) return failedRegistration(getString(R.string.invalid_domain))

        hideKeyboard()
      Severity: Minor
      Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt - About 1 hr to fix

        Method registerAppToServer has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
        Open

            private fun registerAppToServer(normalizedDomain: String) {

        if(!validDomain(normalizedDomain)) return failedRegistration(getString(R.string.invalid_domain))

        hideKeyboard()
        Severity: Minor
        Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method storeUser has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private suspend fun storeUser(accessToken: String, refreshToken: String?, clientId: String, clientSecret: String, instance: String) {
        Severity: Minor
        Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt - About 35 mins to fix

          Avoid too many return statements within this method.
          Open

                          return@launch failedRegistration()
          Severity: Major
          Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            preferences.edit().putString("nodeInfo", Gson().toJson(nodeInfo)).remove("instance").apply()
            Severity: Minor
            Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt and 1 other location - About 45 mins to fix
            app/src/main/java/org/pixeldroid/app/LoginActivity.kt on lines 191..191

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            preferences.edit().putString("instance", Gson().toJson(instance)).remove("nodeInfo").apply()
            Severity: Minor
            Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt and 1 other location - About 45 mins to fix
            app/src/main/java/org/pixeldroid/app/LoginActivity.kt on lines 183..183

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    val nodeInfo: NodeInfo? = gson.fromJson(preferences.getString("nodeInfo", null), NodeInfo::class.java)
            Severity: Minor
            Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt and 1 other location - About 40 mins to fix
            app/src/main/java/org/pixeldroid/app/LoginActivity.kt on lines 253..253

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    val instance: Instance? = gson.fromJson(preferences.getString("instance", null), Instance::class.java)
            Severity: Minor
            Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt and 1 other location - About 40 mins to fix
            app/src/main/java/org/pixeldroid/app/LoginActivity.kt on lines 252..252

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        notifications.forEach{it.user_id = user.user_id; it.instance_uri = user.instance_uri}
            Severity: Minor
            Found in app/src/main/java/org/pixeldroid/app/LoginActivity.kt and 1 other location - About 30 mins to fix
            app/src/main/java/org/pixeldroid/app/posts/feeds/cachedFeeds/notifications/NotificationsRemoteMediator.kt on lines 63..63

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status