Sign upLogin

HR/Crypter

View on GitHub
Star
app/src/masterPassPrompt.js

Summary

Maintainability
A
0 mins
Test Coverage

Function window has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Invalid

exports.window = function (global, resetOnly, callback) {
  let noMP = true // init noMP flag with false
  let error = null
  const CLOSE_TIMEOUT = 2000
Severity: Major
Found in app/src/masterPassPrompt.js - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Invalid

        MasterPass.set(masterpass)
      .then(mpkey => {
        // set the derived MasterPassKey globally
        global.MasterPassKey = new MasterPassKey(mpkey)
        return
    Severity: Major
    Found in app/src/masterPassPrompt.js and 1 other location - About 2 hrs to fix
    app/src/setup.js on lines 34..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status