Sign upLogin

HaaseIT/HCSF

View on GitHub
Star

Showing 151 of 151 total issues

Method preparePage has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager);
        $this->P->cb_pagetype = 'content';
Severity: Major
Found in src/Controller/Shop/Paypalnotify.php - About 3 hrs to fix

    Function getItemSuggestions has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getItemSuggestions(
        Items $oItem,
        $aPossibleSuggestions,
        $sSetSuggestions,
        $sCurrentitem,
    Severity: Minor
    Found in src/Shop/Helper.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generatePage has 91 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function generatePage(Page $P)
    {
        $requesturi = $this->helper->getCleanRequestTarget();

        $aP = [
    Severity: Major
    Found in src/HCSF.php - About 3 hrs to fix

      Function generatePage has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          public function generatePage(Page $P)
    {
        $requesturi = $this->helper->getCleanRequestTarget();

        $aP = [
      Severity: Minor
      Found in src/HCSF.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method preparePage has 88 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager, [], 'admin/base.twig');
        $this->P->cb_pagetype = 'content';
        $this->P->cb_subnav = 'admin';
      Severity: Major
      Found in src/Controller/Admin/Textcatadmin.php - About 3 hrs to fix

        File HCSF.php has 311 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

namespace HaaseIT\HCSF;

use Zend\ServiceManager\ServiceManager;
        Severity: Minor
        Found in src/HCSF.php - About 3 hrs to fix

          Function fillSuggestions has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
          Open

              public function fillSuggestions($suggestions)
    {
        $iNumberOfSuggestions = count($suggestions['default']);
        if ($iNumberOfSuggestions > $this->shop['itemdetail_suggestions']) { // if there are more suggestions than should be displayed, randomly pick as many as to be shown
            $aKeysSuggestions = array_rand($suggestions['default'], $this->shop['itemdetail_suggestions']); // get the array keys that will stay
          Severity: Minor
          Found in src/Shop/Helper.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function seekItem has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
          Open

              public function seekItem(\HaaseIT\HCSF\Page $P, array $aP, Items $oItem)
    {
        // Change pagetype to itemoverview, will be changed back to itemdetail once the item is found
        // if it is not found, we will show the overview
        $aP['pagetype'] = 'itemoverview';
          Severity: Minor
          Found in src/Shop/Helper.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method preparePage has 82 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager, [], 'admin/base.twig');
        $this->P->cb_pagetype = 'content';
        $this->P->cb_subnav = 'admin';
          Severity: Major
          Found in src/Controller/Admin/Shop/Itemadmin.php - About 3 hrs to fix

            Method preparePage has 82 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager);
        $this->P->cb_pagetype = 'content';
            Severity: Major
            Found in src/Controller/Customer/Register.php - About 3 hrs to fix

              Function getNotification has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function getNotification()
    {
        $return = '';
        $getmsg = filter_input(INPUT_GET, 'msg');
        $getcartkey = filter_input(INPUT_GET, 'cartkey', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
              Severity: Minor
              Found in src/Controller/Shop/Shoppingcart.php - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function preparePage has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager, [], 'admin/base.twig');
        $this->P->cb_pagetype = 'content';
        $this->P->cb_subnav = 'admin';
              Severity: Minor
              Found in src/Controller/Admin/Textcatadmin.php - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method preparePage has 79 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager);
        $this->P->cb_pagetype = 'content';
              Severity: Major
              Found in src/Controller/Shop/Myorders.php - About 3 hrs to fix

                Method preparePage has 76 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager);
        $this->P->cb_pagetype = 'content';
                Severity: Major
                Found in src/Controller/Customer/Userhome.php - About 3 hrs to fix

                  Function mailWrapper has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function mailWrapper($to, $subject = '(No subject)', $message = '', $aImagesToEmbed = [], $aFilesToAttach = []) {
        $mail = new \PHPMailer;
        $mail->CharSet = 'UTF-8';

        $mail->isMail();
                  Severity: Minor
                  Found in src/Helper.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getItemPathTree has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getItemPathTree()
    {
        $itemindexpathtree = [];
        $aItemoverviewpages = [];
        $sql = "SELECT * FROM content_base WHERE cb_pagetype = 'itemoverview' OR cb_pagetype = 'itemoverviewgrpd'";
                  Severity: Minor
                  Found in src/Shop/Items.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method preparePage has 72 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager, [], 'admin/base.twig');
        $this->P->cb_pagetype = 'content';
        $this->P->cb_subnav = 'admin';
                  Severity: Major
                  Found in src/Controller/Admin/Shop/Shopadmin.php - About 2 hrs to fix

                    Function sortItems has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function sortItems($mItemIndex = '', $mItemno = '', $bEnableItemGroups = false)
    {
        if ($mItemno !== '') {
            if (\is_array($mItemno)) {
                $TMP = [];
                    Severity: Minor
                    Found in src/Shop/Items.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File de.php has 273 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
return [
    'fullstop' => '.',
    'changescommitted' => 'Änderungen gespeichert:',
                    Severity: Minor
                    Found in src/config/hardcodedtextcats/de.php - About 2 hrs to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      <?php

/*
    HCSF - A multilingual CMS and Shopsystem
    Copyright (C) 2014  Marcus Haase - mail@marcus.haase.name
                      Severity: Major
                      Found in src/Controller/Admin/ClearTemplateCache.php and 1 other location - About 2 hrs to fix
                      src/Controller/Admin/ClearImageCache.php on lines 1..38

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 132.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language