HaaseIT/HCSF

View on GitHub
src/Controller/Admin/Shop/Itemadmin.php

Summary

Maintainability
D
2 days
Test Coverage

Function preparePage has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager, [], 'admin/base.twig');
        $this->P->cb_pagetype = 'content';
        $this->P->cb_subnav = 'admin';
Severity: Minor
Found in src/Controller/Admin/Shop/Itemadmin.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Itemadmin.php has 343 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/*
    HCSF - A multilingual CMS and Shopsystem
    Copyright (C) 2014  Marcus Haase - mail@marcus.haase.name
Severity: Minor
Found in src/Controller/Admin/Shop/Itemadmin.php - About 4 hrs to fix

    Method preparePage has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function preparePage()
        {
            $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager, [], 'admin/base.twig');
            $this->P->cb_pagetype = 'content';
            $this->P->cb_subnav = 'admin';
    Severity: Major
    Found in src/Controller/Admin/Shop/Itemadmin.php - About 3 hrs to fix

      Method updateItem has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function updateItem()
          {
              $purifier = false;
              if ($this->config->getShop('itemtext_enable_purifier')) {
                  $purifier = $this->helper->getPurifier('item');
      Severity: Major
      Found in src/Controller/Admin/Shop/Itemadmin.php - About 2 hrs to fix

        Method prepareItem has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function prepareItem($aItemdata)
            {
                $aData = [
                    'form' => ['action' => Tools::makeLinkHRefWithAddedGetVars('/_admin/itemadmin.html', ['action' => 'showitem', 'itemno' => $aItemdata['base']['itm_no']]),],
                    'id' => $aItemdata['base']['itm_id'],
        Severity: Minor
        Found in src/Controller/Admin/Shop/Itemadmin.php - About 1 hr to fix

          Method getItemlist has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function getItemlist()
              {
                  $sSearchstring = filter_input(INPUT_GET, 'searchstring', FILTER_SANITIZE_SPECIAL_CHARS);
                  $sSearchstring = str_replace('*', '%', $sSearchstring);
          
          
          Severity: Minor
          Found in src/Controller/Admin/Shop/Itemadmin.php - About 1 hr to fix

            Method getItem has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function getItem($sItemno = '')
                {
                    if ($sItemno === '') {
                        $sItemno = filter_input(INPUT_GET, 'itemno', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
                        if (empty($sItemno)) {
            Severity: Minor
            Found in src/Controller/Admin/Shop/Itemadmin.php - About 1 hr to fix

              Method prepareItemlistsearchform has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function prepareItemlistsearchform()
                  {
                      $aData = [
                          'searchcats' => [
                              'nummer|'.$this->hardcodedtextcats->get('itemadmin_search_itemno'),
              Severity: Minor
              Found in src/Controller/Admin/Shop/Itemadmin.php - About 1 hr to fix

                Function getItemlist has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function getItemlist()
                    {
                        $sSearchstring = filter_input(INPUT_GET, 'searchstring', FILTER_SANITIZE_SPECIAL_CHARS);
                        $sSearchstring = str_replace('*', '%', $sSearchstring);
                
                
                Severity: Minor
                Found in src/Controller/Admin/Shop/Itemadmin.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function prepareItem has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function prepareItem($aItemdata)
                    {
                        $aData = [
                            'form' => ['action' => Tools::makeLinkHRefWithAddedGetVars('/_admin/itemadmin.html', ['action' => 'showitem', 'itemno' => $aItemdata['base']['itm_no']]),],
                            'id' => $aItemdata['base']['itm_id'],
                Severity: Minor
                Found in src/Controller/Admin/Shop/Itemadmin.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    private function getItemgroups($iGID = '') // this function should be outsourced, a duplicate is used in admin itemgroups!
                    {
                        $querybuilder = $this->dbal->createQueryBuilder();
                        $querybuilder
                            ->select('*')
                Severity: Major
                Found in src/Controller/Admin/Shop/Itemadmin.php and 1 other location - About 1 hr to fix
                src/Controller/Admin/Shop/Itemgroupadmin.php on lines 280..300

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 118.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status