Sign upLogin

HaaseIT/HCSF

View on GitHub
Star
src/Controller/Shop/Myorders.php

Summary

Maintainability
C
1 day
Test Coverage

Method preparePage has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager);
        $this->P->cb_pagetype = 'content';
Severity: Major
Found in src/Controller/Shop/Myorders.php - About 3 hrs to fix

    Function preparePage has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager);
        $this->P->cb_pagetype = 'content';
    Severity: Minor
    Found in src/Controller/Shop/Myorders.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function showMyOrders has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        private function showMyOrders($COList)
    {
        $return = '';
        $sql = 'SELECT * FROM orders WHERE o_custno = :custno ORDER BY o_ordertimestamp DESC';
    Severity: Minor
    Found in src/Controller/Shop/Myorders.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method showMyOrders has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function showMyOrders($COList)
    {
        $return = '';
        $sql = 'SELECT * FROM orders WHERE o_custno = :custno ORDER BY o_ordertimestamp DESC';
    Severity: Minor
    Found in src/Controller/Shop/Myorders.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status