HabitatMap/AirCasting

View on GitHub
app/javascript/react/api/apiEndpoints.ts

Summary

Maintainability
D
2 days
Test Coverage

Consider simplifying this complex logical expression.
Open

    if (
      west === undefined ||
      east === undefined ||
      south === undefined ||
      north === undefined ||
Severity: Critical
Found in app/javascript/react/api/apiEndpoints.ts - About 2 hrs to fix

    Function fetchUsernames has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      fetchUsernames: (params) => {
        const {
          usernames,
          tags,
          west,
    Severity: Major
    Found in app/javascript/react/api/apiEndpoints.ts - About 2 hrs to fix

      Function fetchTags has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        fetchTags: (params) => {
          const {
            tags,
            west,
            east,
      Severity: Major
      Found in app/javascript/react/api/apiEndpoints.ts - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

            if (
              west === undefined ||
              east === undefined ||
              south === undefined ||
              north === undefined ||
        Severity: Critical
        Found in app/javascript/react/api/apiEndpoints.ts - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                west === undefined ||
                east === undefined ||
                south === undefined ||
                north === undefined ||
                timeFrom === undefined ||
          Severity: Major
          Found in app/javascript/react/api/apiEndpoints.ts and 1 other location - About 2 hrs to fix
          app/javascript/react/api/apiEndpoints.ts on lines 135..144

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                west === undefined ||
                east === undefined ||
                south === undefined ||
                north === undefined ||
                timeFrom === undefined ||
          Severity: Major
          Found in app/javascript/react/api/apiEndpoints.ts and 1 other location - About 2 hrs to fix
          app/javascript/react/api/apiEndpoints.ts on lines 71..80

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const {
                usernames,
                tags,
                west,
                east,
          Severity: Major
          Found in app/javascript/react/api/apiEndpoints.ts and 1 other location - About 1 hr to fix
          app/javascript/react/api/apiEndpoints.ts on lines 118..132

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const {
                tags,
                west,
                east,
                south,
          Severity: Major
          Found in app/javascript/react/api/apiEndpoints.ts and 1 other location - About 1 hr to fix
          app/javascript/react/api/apiEndpoints.ts on lines 54..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              const queryString = Object.keys(query)
                .map(
                  (key) =>
                    `${encodeParamName(key)}=${encodeURIComponent(String(query[key]))}`
                )
          Severity: Major
          Found in app/javascript/react/api/apiEndpoints.ts and 1 other location - About 1 hr to fix
          app/javascript/react/api/apiEndpoints.ts on lines 106..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 64.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              const queryString = Object.keys(query)
                .map(
                  (key) =>
                    `${encodeParamName(key)}=${encodeURIComponent(String(query[key]))}`
                )
          Severity: Major
          Found in app/javascript/react/api/apiEndpoints.ts and 1 other location - About 1 hr to fix
          app/javascript/react/api/apiEndpoints.ts on lines 168..173

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 64.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status