Sign upLogin

HabitatMap/AirCasting

View on GitHub
Star
app/javascript/react/components/Map/Map.tsx

Summary

Maintainability
F
1 wk
Test Coverage

Function Map has 733 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Map = () => {
  const dispatch = useAppDispatch();
  const {
    boundEast,
    boundNorth,
Severity: Major
Found in app/javascript/react/components/Map/Map.tsx - About 3 days to fix

    File Map.tsx has 830 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, {
  useCallback,
  useEffect,
  useMemo,
  useRef,
    Severity: Major
    Found in app/javascript/react/components/Map/Map.tsx - About 1 day to fix

      Function Map has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
      Open

      const Map = () => {
  const dispatch = useAppDispatch();
  const {
    boundEast,
    boundNorth,
      Severity: Minor
      Found in app/javascript/react/components/Map/Map.tsx - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handleMarkerClick has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const handleMarkerClick = (
    selectedStreamId: number | null,
    id: number | null
  ) => {
    if (currentUserSettings !== UserSettings.SessionListView) {
      Severity: Major
      Found in app/javascript/react/components/Map/Map.tsx - About 2 hrs to fix

        Function handleMapIdle has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            (event: MapEvent) => {
      const map = event.map;
      if (!mapInstance) {
        setMapInstance(map);
        map.setOptions({
        Severity: Minor
        Found in app/javascript/react/components/Map/Map.tsx - About 1 hr to fix

          Function setPreviousZoomInTheURL has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const setPreviousZoomInTheURL = () => {
    const desktopCondition: boolean =
      !isMobile &&
      currentUserSettings !== UserSettings.ModalView &&
      previousUserSettings !== UserSettings.CalendarView;
          Severity: Minor
          Found in app/javascript/react/components/Map/Map.tsx - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                        if (isActive) {
              dispatch(
                fetchActiveIndoorSessions({ filters: indoorSessionsFilters })
              ).unwrap();
            } else {
            Severity: Major
            Found in app/javascript/react/components/Map/Map.tsx - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          if (isActive) {
              dispatch(fetchActiveFixedSessions({ filters })).unwrap();
            } else {
              dispatch(fetchDormantFixedSessions({ filters })).unwrap();
            }
              Severity: Major
              Found in app/javascript/react/components/Map/Map.tsx - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            <SectionButton
              title={t("map.legendTile")}
              image={mapLegend}
              alt={t("map.altlegendTile")}
              onClick={() => goToUserSettings(UserSettings.MapLegendView)}
                Severity: Major
                Found in app/javascript/react/components/Map/Map.tsx and 1 other location - About 2 hrs to fix
                app/javascript/react/components/Map/Map.tsx on lines 788..795

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 76.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            <SectionButton
              title={t("map.listSessions")}
              image={pinImage}
              alt={t("map.altListSessions")}
              onClick={() => goToUserSettings(UserSettings.SessionListView)}
                Severity: Major
                Found in app/javascript/react/components/Map/Map.tsx and 1 other location - About 2 hrs to fix
                app/javascript/react/components/Map/Map.tsx on lines 796..803

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 76.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            sessions={listSessions.map((session: SessionList) => ({
              id: session.id,
              sessionName: session.title,
              sensorName: session.sensorName,
              averageValue: session.averageValue,
                Severity: Major
                Found in app/javascript/react/components/Map/Map.tsx and 1 other location - About 1 hr to fix
                app/javascript/react/components/Map/Map.tsx on lines 868..876

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                              sessions={listSessions.map((session) => ({
                id: session.id,
                sessionName: session.title,
                sensorName: session.sensorName,
                averageValue: session.averageValue,
                Severity: Major
                Found in app/javascript/react/components/Map/Map.tsx and 1 other location - About 1 hr to fix
                app/javascript/react/components/Map/Map.tsx on lines 830..838

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if (isIndoorParameterInUrl) {
            if (isActive) {
              dispatch(
                fetchActiveIndoorSessions({ filters: indoorSessionsFilters })
              ).unwrap();
                Severity: Major
                Found in app/javascript/react/components/Map/Map.tsx and 1 other location - About 1 hr to fix
                app/javascript/react/components/Map/Map.tsx on lines 359..365

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 62.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          } else {
            if (isActive) {
              dispatch(fetchActiveFixedSessions({ filters })).unwrap();
            } else {
              dispatch(fetchDormantFixedSessions({ filters })).unwrap();
                Severity: Major
                Found in app/javascript/react/components/Map/Map.tsx and 1 other location - About 1 hr to fix
                app/javascript/react/components/Map/Map.tsx on lines 349..359

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 62.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            onClose={() =>
              [UserSettings.CrowdMapView].includes(previousUserSettings)
                ? goToUserSettings(UserSettings.CrowdMapView)
                : goToUserSettings(UserSettings.MapView)
            }
                Severity: Minor
                Found in app/javascript/react/components/Map/Map.tsx and 1 other location - About 35 mins to fix
                app/javascript/react/components/Map/Map.tsx on lines 853..857

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            onClose={() =>
              [UserSettings.CrowdMapView].includes(previousUserSettings)
                ? goToUserSettings(UserSettings.CrowdMapView)
                : goToUserSettings(UserSettings.MapView)
            }
                Severity: Minor
                Found in app/javascript/react/components/Map/Map.tsx and 1 other location - About 35 mins to fix
                app/javascript/react/components/Map/Map.tsx on lines 842..846

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status