Sign upLogin

HabitatMap/AirCasting

View on GitHub
Star
app/javascript/react/components/Map/Markers/MobileMarkers.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function MobileMarkers has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

const MobileMarkers = ({
  sessions,
  onMarkerClick,
  selectedStreamId,
  pulsatingSessionId,
Severity: Minor
Found in app/javascript/react/components/Map/Markers/MobileMarkers.tsx - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MobileMarkers.tsx has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use client";

import { useMap } from "@vis.gl/react-google-maps";
import { useCallback, useEffect, useRef, useState } from "react";
import { useSelector } from "react-redux";
Severity: Minor
Found in app/javascript/react/components/Map/Markers/MobileMarkers.tsx - About 2 hrs to fix

    Function updateMarkers has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const updateMarkers = useCallback(() => {
    markerRefs.current.forEach((marker, streamId) => {
      const session = sessions.find((s) => s.point.streamId === streamId);
      if (!session) return;
    Severity: Major
    Found in app/javascript/react/components/Map/Markers/MobileMarkers.tsx - About 2 hrs to fix

      Function centerMapOnBounds has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          (
      minLatitude: number,
      maxLatitude: number,
      minLongitude: number,
      maxLongitude: number
      Severity: Minor
      Found in app/javascript/react/components/Map/Markers/MobileMarkers.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        type Props = {
  sessions: Session[];
  onMarkerClick: (streamId: number | null, id: number | null) => void;
  selectedStreamId: number | null;
  pulsatingSessionId: number | null;
        Severity: Major
        Found in app/javascript/react/components/Map/Markers/MobileMarkers.tsx and 1 other location - About 1 hr to fix
        app/javascript/react/components/Map/Markers/DormantMarkers.tsx on lines 25..30

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (!overlay) {
          overlay = new CustomMarkerOverlay(
            marker.getPosition()!,
            color,
            isSelected,
        Severity: Minor
        Found in app/javascript/react/components/Map/Markers/MobileMarkers.tsx and 1 other location - About 35 mins to fix
        app/javascript/react/components/Map/Markers/FixedMarkers.tsx on lines 325..339

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                () => {
          onMarkerClick(Number(session.point.streamId), Number(session.id));
          centerMapOnMarker(session.point);
        },
        Severity: Minor
        Found in app/javascript/react/components/Map/Markers/MobileMarkers.tsx and 1 other location - About 30 mins to fix
        app/javascript/react/components/Map/Markers/FixedMarkers.tsx on lines 215..218

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status