Sign upLogin

HabitatMap/AirCasting

View on GitHub
Star
app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function ThresholdSlider has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

const ThresholdSlider: React.FC<ThresholdSliderProps> = ({
  isMobileOldStyle,
  useColorBoxStyle,
  setErrorMessage,
}) => {
Severity: Minor
Found in app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ThresholdSlider.tsx has 346 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import _ from "lodash";
import React, {
  useCallback,
  useEffect,
  useLayoutEffect,
Severity: Minor
Found in app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx - About 4 hrs to fix

    Function updateThumbPositionsHandler has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const updateThumbPositionsHandler = useCallback(() => {
    if (sliderRef.current) {
      const { min, low, middle, high, max } = thresholdValues;
      const lowThumb = calculateThumbPosition(
        low,
    Severity: Minor
    Found in app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            <S.ColorBoxNumberInput
        inputMode="numeric"
        type="number"
        step={1}
        value={activeInput === "min" ? inputValue : min.toString()}
      Severity: Major
      Found in app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx and 1 other location - About 4 hrs to fix
      app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx on lines 347..356

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 115.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            <S.ColorBoxNumberInput
        inputMode="numeric"
        type="number"
        step={5}
        value={activeInput === "max" ? inputValue : max.toString()}
      Severity: Major
      Found in app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx and 1 other location - About 4 hrs to fix
      app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx on lines 319..328

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 115.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                    onTouchStart={(event: React.TouchEvent<HTMLInputElement>) =>
                handleTouchStart(
                  thresholdKey,
                  thresholdValues,
                  sliderWidth,
      Severity: Major
      Found in app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx and 1 other location - About 1 hr to fix
      app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx on lines 211..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            onTouchStart={(event: React.TouchEvent<HTMLInputElement>) =>
        handleTouchStart(
          thresholdKey,
          thresholdValues,
          sliderWidth,
      Severity: Major
      Found in app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx and 1 other location - About 1 hr to fix
      app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx on lines 289..298

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        useEffect(() => {
    document.addEventListener("click", handleOutsideClick);
    return () => {
      document.removeEventListener("click", handleOutsideClick);
    };
      Severity: Minor
      Found in app/javascript/react/components/ThresholdConfigurator/ThresholdSlider.tsx and 1 other location - About 35 mins to fix
      app/javascript/react/components/Modals/TimelapseModal/TimelapseComponent.tsx on lines 113..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status