Sign upLogin

HabitatMap/AirCasting

View on GitHub
Star
app/javascript/react/store/indoorSessionsSlice.ts

Summary

Maintainability
D
2 days
Test Coverage

Function extraReducers has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  extraReducers: (builder) => {
    builder
      .addCase(fetchActiveIndoorSessions.pending, (state) => {
        state.status = StatusEnum.Pending;
        state.error = null;
Severity: Minor
Found in app/javascript/react/store/indoorSessionsSlice.ts - About 1 hr to fix

    Function createSessionFetchThunk has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const createSessionFetchThunk = (
  type: FixedSessionsTypes,
  endpoint: (filters: string) => string
) => {
  return createAsyncThunk<
    Severity: Minor
    Found in app/javascript/react/store/indoorSessionsSlice.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      const createSessionFetchThunk = (
  type: FixedSessionsTypes,
  endpoint: (filters: string) => string
) => {
  return createAsyncThunk<
      Severity: Major
      Found in app/javascript/react/store/indoorSessionsSlice.ts and 1 other location - About 1 day to fix
      app/javascript/react/store/fixedSessionsSlice.ts on lines 63..106

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 330.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

          builder
      .addCase(fetchActiveIndoorSessions.pending, (state) => {
        state.status = StatusEnum.Pending;
        state.error = null;
      })
      Severity: Major
      Found in app/javascript/react/store/indoorSessionsSlice.ts and 6 other locations - About 1 hr to fix
      app/javascript/react/store/fixedSessionsSlice.ts on lines 133..154
      app/javascript/react/store/fixedSessionsSlice.ts on lines 155..175
      app/javascript/react/store/indoorSessionsSlice.ts on lines 109..149
      app/javascript/react/store/mobileSessionsSlice.ts on lines 116..141
      app/javascript/react/store/sensorsSlice.ts on lines 63..84
      app/javascript/react/store/thresholdSlice.ts on lines 77..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        streams: {
    [key: string]: {
      streamDailyAverage: number;
      measurementShortType: string;
      sensorName: string;
      Severity: Major
      Found in app/javascript/react/store/indoorSessionsSlice.ts and 1 other location - About 1 hr to fix
      app/javascript/react/store/fixedSessionsSlice.ts on lines 22..30

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status