Sign upLogin

HabitatMap/AirCasting

View on GitHub
Star
spec/controllers/api/user_sessions_controller_spec.rb

Summary

Maintainability
C
1 day
Test Coverage

File user_sessions_controller_spec.rb has 333 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rails_helper'

describe Api::UserSessionsController do
  let(:user) { FactoryBot.create(:user) }
Severity: Minor
Found in spec/controllers/api/user_sessions_controller_spec.rb - About 4 hrs to fix

    Method session_data has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def session_data(attributes)
    "[
    {\"calibration\":0,
      \"contribute\":true,
      \"drawable\":2131165435,
    Severity: Minor
    Found in spec/controllers/api/user_sessions_controller_spec.rb - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          it 'deletes a session and returns it as deleted if it was mark for deletion' do
      session = create_session!(user: user, uuid: 'abc')

      post :sync,
           format: :json,
      Severity: Minor
      Found in spec/controllers/api/user_sessions_controller_spec.rb and 1 other location - About 55 mins to fix
      spec/controllers/api/user_sessions_controller_spec.rb on lines 316..328

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          it 'deletes a session and returns it as deleted if it was mark for deletion' do
      session = create_session!(user: user, uuid: 'abc')

      post :sync_with_versioning,
           format: :json,
      Severity: Minor
      Found in spec/controllers/api/user_sessions_controller_spec.rb and 1 other location - About 55 mins to fix
      spec/controllers/api/user_sessions_controller_spec.rb on lines 35..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          it "returns session as deleted when it's already deleted in the db" do
      session = create_session!(user: user, uuid: 'abc')
      session.destroy

      post :sync, format: :json, params: { data: session_data(uuid: 'abc') }
      Severity: Minor
      Found in spec/controllers/api/user_sessions_controller_spec.rb and 1 other location - About 45 mins to fix
      spec/controllers/api/user_sessions_controller_spec.rb on lines 301..313

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          it "returns session as deleted when it's already deleted in the db" do
      session = create_session!(user: user, uuid: 'abc')
      session.destroy

      post :sync_with_versioning,
      Severity: Minor
      Found in spec/controllers/api/user_sessions_controller_spec.rb and 1 other location - About 45 mins to fix
      spec/controllers/api/user_sessions_controller_spec.rb on lines 24..32

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          it "returns session for upload when it's not present in the db" do
      post :sync_with_versioning,
           format: :json,
           params: {
             data: session_data2(uuid: 'abc')
      Severity: Minor
      Found in spec/controllers/api/user_sessions_controller_spec.rb and 1 other location - About 25 mins to fix
      spec/controllers/api/user_sessions_controller_spec.rb on lines 10..15

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          it "returns session for upload when it's not present in the db" do
      post :sync, format: :json, params: { data: session_data(uuid: 'abc') }

      expected = { 'download' => [], 'upload' => %w[abc], 'deleted' => [] }
      Severity: Minor
      Found in spec/controllers/api/user_sessions_controller_spec.rb and 1 other location - About 25 mins to fix
      spec/controllers/api/user_sessions_controller_spec.rb on lines 289..298

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status