Sign upLogin

HabitatMap/AirCasting

View on GitHub
Star
spec/services/csv/append_measurements_content_spec.rb

Summary

Maintainability
D
1 day
Test Coverage

File append_measurements_content_spec.rb has 541 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rails_helper'

describe Csv::AppendMeasurementsContent do
  before(:each) { @subject = Csv::AppendMeasurementsContent.new }
Severity: Major
Found in spec/services/csv/append_measurements_content_spec.rb - About 1 day to fix

    Method build_data has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        amount_of_streams,
    measurements,
    sensor_package_name,
    session_id,
    stream_parameters
    Severity: Minor
    Found in spec/services/csv/append_measurements_content_spec.rb - About 35 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        it 'with two streams appends the correct measurement units in the eighth line' do
    amount_of_streams = 2
    measurement_units_1 = 'micrograms per cubic meter'
    measurement_units_2 = 'Fahrenheit'
    stream_parameters =
      Severity: Major
      Found in spec/services/csv/append_measurements_content_spec.rb and 2 other locations - About 50 mins to fix
      spec/services/csv/append_measurements_content_spec.rb on lines 228..239
      spec/services/csv/append_measurements_content_spec.rb on lines 242..255

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        it 'with two streams appends the correct measurement types in the sixth line' do
    amount_of_streams = 2
    measurement_type_1 = 'Particulate Matter'
    measurement_type_2 = 'Temperature'
    stream_parameters =
      Severity: Major
      Found in spec/services/csv/append_measurements_content_spec.rb and 2 other locations - About 50 mins to fix
      spec/services/csv/append_measurements_content_spec.rb on lines 228..239
      spec/services/csv/append_measurements_content_spec.rb on lines 258..271

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        it 'with two streams appends the correct sensor names in the fourth line' do
    amount_of_streams = 2
    sensor_name_1 = 'AirBeam2-F'
    sensor_name_2 = 'AirBeam2-PM1'
    stream_parameters =
      Severity: Major
      Found in spec/services/csv/append_measurements_content_spec.rb and 2 other locations - About 50 mins to fix
      spec/services/csv/append_measurements_content_spec.rb on lines 242..255
      spec/services/csv/append_measurements_content_spec.rb on lines 258..271

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 42.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          measurements = [
      {
        'measurement_time' => time,
        'measurement_milliseconds' => milliseconds,
        'measurement_latitude' => latitude,
      Severity: Minor
      Found in spec/services/csv/append_measurements_content_spec.rb and 3 other locations - About 30 mins to fix
      spec/services/csv/append_measurements_content_spec.rb on lines 347..366
      spec/services/csv/append_measurements_content_spec.rb on lines 417..436
      spec/services/csv/append_measurements_content_spec.rb on lines 491..510

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          measurements = [
      {
        'measurement_time' => time_1,
        'measurement_milliseconds' => milliseconds_1,
        'measurement_latitude' => latitude,
      Severity: Minor
      Found in spec/services/csv/append_measurements_content_spec.rb and 3 other locations - About 30 mins to fix
      spec/services/csv/append_measurements_content_spec.rb on lines 288..307
      spec/services/csv/append_measurements_content_spec.rb on lines 347..366
      spec/services/csv/append_measurements_content_spec.rb on lines 491..510

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          measurements = [
      {
        'measurement_time' => time_1,
        'measurement_milliseconds' => milliseconds_1,
        'measurement_latitude' => latitude_1,
      Severity: Minor
      Found in spec/services/csv/append_measurements_content_spec.rb and 3 other locations - About 30 mins to fix
      spec/services/csv/append_measurements_content_spec.rb on lines 288..307
      spec/services/csv/append_measurements_content_spec.rb on lines 347..366
      spec/services/csv/append_measurements_content_spec.rb on lines 417..436

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          measurements = [
      {
        'measurement_time' => time,
        'measurement_milliseconds' => milliseconds,
        'measurement_latitude' => latitude_1,
      Severity: Minor
      Found in spec/services/csv/append_measurements_content_spec.rb and 3 other locations - About 30 mins to fix
      spec/services/csv/append_measurements_content_spec.rb on lines 288..307
      spec/services/csv/append_measurements_content_spec.rb on lines 417..436
      spec/services/csv/append_measurements_content_spec.rb on lines 491..510

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status