Sign upLogin

Hack23/cia

View on GitHub
Star
citizen-intelligence-agency/src/main/java/com/hack23/cia/web/impl/ui/application/views/common/converters/ListPropertyConverter.java

Summary

Maintainability
A
30 mins
Test Coverage

Provide the parametrized type for this generic.
Open

    public String convertToPresentation(final List value, final ValueContext context) {
Severity: Major
Found in citizen-intelligence-agency/src/main/java/com/hack23/cia/web/impl/ui/application/views/common/converters/ListPropertyConverter.java by sonar-java

Generic types shouldn't be used raw (without type parameters) in variable declarations or return values. Doing so bypasses generic type checking, and defers the catch of unsafe code to runtime.

Noncompliant Code Example

List myList; // Noncompliant
Set mySet; // Noncompliant

Compliant Solution

List<String> myList;
Set<? extends Number> mySet;

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public ListPropertyConverter(final String property, final String column, final String fallbackColumn) {
        super();
        this.property = property;
        this.column = column;
        this.fallbackColumn = fallbackColumn;
Severity: Minor
Found in citizen-intelligence-agency/src/main/java/com/hack23/cia/web/impl/ui/application/views/common/converters/ListPropertyConverter.java and 1 other location - About 30 mins to fix
service.impl/src/main/java/com/hack23/cia/service/impl/UserConfigurationImpl.java on lines 47..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status