Sign upLogin

Hack23/cia

View on GitHub
Star
service.data.impl/src/main/java/com/hack23/cia/service/data/impl/AbstractGenericDAOImpl.java

Summary

Maintainability
C
1 day
Test Coverage

AbstractGenericDAOImpl has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

abstract class AbstractGenericDAOImpl<T extends Serializable, I extends Serializable>
        implements AbstractGenericDAO<T, I> {

    private static final int MAX_IN_VARIABLES = 30000;
Severity: Minor
Found in service.data.impl/src/main/java/com/hack23/cia/service/data/impl/AbstractGenericDAOImpl.java - About 3 hrs to fix

    File AbstractGenericDAOImpl.java has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright 2010-2021 James Pether Sörling
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
    Severity: Minor
    Found in service.data.impl/src/main/java/com/hack23/cia/service/data/impl/AbstractGenericDAOImpl.java - About 2 hrs to fix

      Method findOrderedByPropertyListByEmbeddedProperty has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public <V> List<T> findOrderedByPropertyListByEmbeddedProperty(final SingularAttribute<T, V> property,
            final Class<V> clazz2, final SingularAttribute<V, ? extends Object> property2, final Object value,
            final SingularAttribute<T, ? extends Object> orderByProperty) {
      Severity: Minor
      Found in service.data.impl/src/main/java/com/hack23/cia/service/data/impl/AbstractGenericDAOImpl.java - About 35 mins to fix

        Define a constant instead of duplicating this literal "findListByProperty" 3 times.
        Open

                addCacheHints(typedQuery, "findListByProperty");
        Severity: Critical
        Found in service.data.impl/src/main/java/com/hack23/cia/service/data/impl/AbstractGenericDAOImpl.java by sonar-java

        Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

        On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

        Noncompliant Code Example

        With the default threshold of 3:

        public void run() {
  prepare("action1");                              // Noncompliant - "action1" is duplicated 3 times
  execute("action1");
  release("action1");
}

@SuppressWarning("all")                            // Compliant - annotations are excluded
private void method1() { /* ... */ }
@SuppressWarning("all")
private void method2() { /* ... */ }

public String method3(String a) {
  System.out.println("'" + a + "'");               // Compliant - literal "'" has less than 5 characters and is excluded
  return "";                                       // Compliant - literal "" has less than 5 characters and is excluded
}

        Compliant Solution

        private static final String ACTION_1 = "action1";  // Compliant

public void run() {
  prepare(ACTION_1);                               // Compliant
  execute(ACTION_1);
  release(ACTION_1);
}

        Exceptions

        To prevent generating some false-positives, literals having less than 5 characters are excluded.

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (values.length > 1) {
            for (int i = 1; i < properties.length; i++) {
                final SingularAttribute<T, ? extends Object> property2 = properties[i];
                final Object value2 = values[i];
                final Predicate condition2 = QueryHelper.equalsIgnoreCaseIfStringPredicate(criteriaBuilder, root,
        Severity: Major
        Found in service.data.impl/src/main/java/com/hack23/cia/service/data/impl/AbstractGenericDAOImpl.java and 1 other location - About 1 hr to fix
        service.data.impl/src/main/java/com/hack23/cia/service/data/impl/AbstractGenericDAOImpl.java on lines 185..194

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (values.length > 1) {
            for (int i = 1; i < properties.length; i++) {
                final SingularAttribute<T, ? extends Object> property2 = properties[i];
                final Object value2 = values[i];
                final Predicate condition2 = QueryHelper.equalsIgnoreCaseIfStringPredicate(criteriaBuilder, root,
        Severity: Major
        Found in service.data.impl/src/main/java/com/hack23/cia/service/data/impl/AbstractGenericDAOImpl.java and 1 other location - About 1 hr to fix
        service.data.impl/src/main/java/com/hack23/cia/service/data/impl/AbstractGenericDAOImpl.java on lines 153..162

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status