Sign upLogin

Hack23/cia

View on GitHub
Star
service.impl/src/main/java/com/hack23/cia/service/impl/action/user/DeleteAccountService.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method processService has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    @Secured({ "ROLE_USER", "ROLE_ADMIN"})
    public DeleteAccountResponse processService(
            final DeleteAccountRequest serviceRequest) {
Severity: Minor
Found in service.impl/src/main/java/com/hack23/cia/service/impl/action/user/DeleteAccountService.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method processService has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    @Secured({ "ROLE_USER", "ROLE_ADMIN"})
    public DeleteAccountResponse processService(
            final DeleteAccountRequest serviceRequest) {
Severity: Minor
Found in service.impl/src/main/java/com/hack23/cia/service/impl/action/user/DeleteAccountService.java - About 1 hr to fix

    Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed.
    Open

        public DeleteAccountResponse processService(
    Severity: Critical
    Found in service.impl/src/main/java/com/hack23/cia/service/impl/action/user/DeleteAccountService.java by sonar-java

    Cognitive Complexity is a measure of how hard the control flow of a method is to understand. Methods with high Cognitive Complexity will be difficult to maintain.

    See

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

        @Override
    protected CreateApplicationEventRequest createApplicationEventForService(
            final DeleteAccountRequest serviceRequest) {
        final CreateApplicationEventRequest eventRequest = createBaseApplicationEventRequest();
        eventRequest.setEventGroup(ApplicationEventGroup.USER);
    Severity: Major
    Found in service.impl/src/main/java/com/hack23/cia/service/impl/action/user/DeleteAccountService.java and 10 other locations - About 45 mins to fix
    service.impl/src/main/java/com/hack23/cia/service/impl/action/admin/ManageUserAccountService.java on lines 137..145
    service.impl/src/main/java/com/hack23/cia/service/impl/action/admin/RefreshDataViewsService.java on lines 76..84
    service.impl/src/main/java/com/hack23/cia/service/impl/action/admin/SendEmailService.java on lines 72..80
    service.impl/src/main/java/com/hack23/cia/service/impl/action/admin/UpdateApplicationConfigurationService.java on lines 94..103
    service.impl/src/main/java/com/hack23/cia/service/impl/action/admin/UpdateSearchIndexService.java on lines 90..98
    service.impl/src/main/java/com/hack23/cia/service/impl/action/application/LogoutService.java on lines 95..103
    service.impl/src/main/java/com/hack23/cia/service/impl/action/user/ChangePasswordService.java on lines 155..164
    service.impl/src/main/java/com/hack23/cia/service/impl/action/user/DisableGoogleAuthenticatorCredentialService.java on lines 104..113
    service.impl/src/main/java/com/hack23/cia/service/impl/action/user/SearchDocumentService.java on lines 109..117
    service.impl/src/main/java/com/hack23/cia/service/impl/action/user/SetGoogleAuthenticatorCredentialService.java on lines 129..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status