Sign upLogin

HackAssistant/registration

View on GitHub
Star
app/views.py

Summary

Maintainability
C
1 day
Test Coverage

Function protectedMedia has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

def protectedMedia(request, file_):
    path, file_name = os.path.split(file_)
    downloadable_path = None
    if path == "resumes":
        try:
Severity: Minor
Found in app/views.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function root_view has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def root_view(request):
    if not request.user.is_authenticated and not utils.is_app_closed():
        return HttpResponseRedirect(reverse('account_signup'))
    if not request.user.is_authenticated and utils.is_app_closed():
        return HttpResponseRedirect(reverse('account_login'))
Severity: Minor
Found in app/views.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return HttpResponseRedirect(reverse('dashboard'))
Severity: Major
Found in app/views.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return HttpResponseRedirect(reverse('sponsor_dashboard'))
    Severity: Major
    Found in app/views.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return HttpResponseRedirect(reverse('check_in_list'))
      Severity: Major
      Found in app/views.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return HttpResponseRedirect(reverse('review'))
        Severity: Major
        Found in app/views.py - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if request.user.is_authenticated and (request.user.is_organizer or
                                              (app and (app.hacker_id == request.user.id))):
            downloadable_path = app.receipt.path
          Severity: Major
          Found in app/views.py and 1 other location - About 1 hr to fix
          app/views.py on lines 54..56

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if request.user.is_authenticated and (request.user.is_organizer or
                                              (app and (app.user_id == request.user.id))):
            downloadable_path = app.resume.path
          Severity: Major
          Found in app/views.py and 1 other location - About 1 hr to fix
          app/views.py on lines 59..61

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status