Sign upLogin

Halyul/hexo-theme-mdui

View on GitHub
Star
source/js/_files/smooth-scroll.js

Summary

Maintainability
D
2 days
Test Coverage

File smooth-scroll.js has 351 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * smooth-scroll v15.2.0
 * Animate scrolling to anchor links
 * (c) 2019 Chris Ferdinandi
 * MIT License
Severity: Minor
Found in source/js/_files/smooth-scroll.js - About 4 hrs to fix

    Function SmoothScroll has 105 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var SmoothScroll = function (selector, options) {

        //
        // Variables
        //
    Severity: Major
    Found in source/js/_files/smooth-scroll.js - About 4 hrs to fix

      Consider simplifying this complex logical expression.
      Open

                  if (
                // If the character is in the range [\1-\1F] (U+0001 to U+001F) or is
                // U+007F, […]
                (codeUnit >= 0x0001 && codeUnit <= 0x001F) || codeUnit == 0x007F ||
                // If the character is the first character and is in the range [0-9]
      Severity: Critical
      Found in source/js/_files/smooth-scroll.js - About 2 hrs to fix

        Function animateScroll has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                smoothScroll.animateScroll = function (anchor, toggle, options) {

            // Cancel any in progress scrolls
            smoothScroll.cancelScroll();
        Severity: Minor
        Found in source/js/_files/smooth-scroll.js - About 1 hr to fix

          Function escapeCharacters has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              var escapeCharacters = function (id) {

        // Remove leading hash
        if (id.charAt(0) === '#') {
            id = id.substr(1);
          Severity: Minor
          Found in source/js/_files/smooth-scroll.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                        if (
                codeUnit >= 0x0080 ||
                codeUnit === 0x002D ||
                codeUnit === 0x005F ||
                codeUnit >= 0x0030 && codeUnit <= 0x0039 ||
            Severity: Critical
            Found in source/js/_files/smooth-scroll.js - About 1 hr to fix

              Function closest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  Element.prototype.closest = function(s) {
        var matches = (this.document || this.ownerDocument).querySelectorAll(s),
            i,
            el = this;
        do {
              Severity: Minor
              Found in source/js/_files/smooth-scroll.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                          if (toggle.hostname !== window.location.hostname || toggle.pathname !== window.location.pathname || !/#/.test(toggle.href)) return;
              Severity: Major
              Found in source/js/_files/smooth-scroll.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            if (!anchor) return;
                Severity: Major
                Found in source/js/_files/smooth-scroll.js - About 30 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      function CustomEvent(event, params) {
        params = params || { bubbles: false, cancelable: false, detail: undefined };
        var evt = document.createEvent('CustomEvent');
        evt.initCustomEvent(event, params.bubbles, params.cancelable, params.detail);
        return evt;
                  Severity: Major
                  Found in source/js/_files/smooth-scroll.js and 1 other location - About 2 hrs to fix
                  source/js/_files/lightgallery.js on lines 223..232

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 81.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status