HashtagsXRep/hashtagsxrep

View on GitHub

Showing 50 of 50 total issues

Method pollProposal has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      @PathVariable("pollId") String pollId,
      @RequestParam("hashtag")
          String hashtag,
      @RequestParam("subject")
          String subject,

    Method cachedMonitorRepository has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          JdbcMonitorRepository jdbcMonitorRepository,
          @Qualifier("monitorCache") LoadingCache<String, Monitor> monitorCache,
          @Qualifier("monitorListCache") LoadingCache<String, List<Monitor>> monitorListCache,
          @Qualifier("reportCache") LoadingCache<String, Report> reportCache,
          @Qualifier("rankingCache") LoadingCache<String, Ranking> rankingCache) {

      Method monitorDataExtractionUseCase has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            @Value("${app.monitor.extraction.maxRequests}") Integer maxExtractionRequests,
            TwitterExtractionRepository twitterExtractionRepository,
            TwitterRepository twitterRepository,
            MonitorRepository monitorRepository,
            PollRepository pollRepository) {

        Method create has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          public Proposal create(String pollId, String authorId, String authorNickname, String hashtag, String subject) {

          Method extractAuthToken has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            public AuthToken extractAuthToken(HttpServletRequest request) {
              if (request.getCookies() != null) {
                for (Cookie cookie : request.getCookies()) {
                  if (cookieName.equals(cookie.getName()) && !COOKIE_LOGOUT.equals(cookie.getValue())) {
                    return deserialize(cookie.getValue());

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            @Autowired
            public GetMembersRankingUseCase(
                GroupRepository groupRepository,
                RankingRepository rankingRepository,
                UserRepository userRepository) {
          src/main/java/cat/xarxarepublicana/hashtagsxrep/infrastructure/controller/MonitorController.java on lines 28..36

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            @Autowired
            public MonitorController(
                CreateMonitorUseCase createMonitorUseCase,
                ListMonitorUseCase listMonitorUseCase,
                DeleteMonitorUseCase deleteMonitorUseCase) {
          src/main/java/cat/xarxarepublicana/hashtagsxrep/application/group/GetMembersRankingUseCase.java on lines 24..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          package cat.xarxarepublicana.hashtagsxrep;
          
          import java.util.Collections;
          import org.springframework.boot.SpringApplication;
          import org.springframework.boot.autoconfigure.SpringBootApplication;
          src/integrationTest/java/cat/xarxarepublicana/hashtagsxrep/HashtagsXRepTestApplication.java on lines 1..18

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 41.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          package cat.xarxarepublicana.hashtagsxrep;
          
          import java.util.Collections;
          import org.springframework.boot.SpringApplication;
          import org.springframework.boot.autoconfigure.SpringBootApplication;
          src/main/java/cat/xarxarepublicana/hashtagsxrep/HashtagsXRepApplication.java on lines 1..18

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 41.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method countTweets has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            public Integer countTweets(String hashtag, Integer max) {
              String queryString = new StringBuffer()
                  .append("count=").append(MAX_TWEETS_PER_QUERY)
                  .append("&q=").append(hashtag)
                  .toString();

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language