Sign upLogin

Hawatel/hawatel_ps

View on GitHub
Star

Showing 25 of 25 total issues

Method search_by_condition has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

        def search_by_condition(args)
          refresh
          attr = args[:attr]
          oper  = args[:oper]
          value = args[:value]
Severity: Minor
Found in lib/hawatel_ps/linux/proc_table.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method search_by_condition has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

        def search_by_condition(args)
          find_all

          attrs = args[:attr]
          oper  = args[:oper]
Severity: Minor
Found in lib/hawatel_ps/windows/proc_table.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for search_by_condition is too high. [21/10]
Open

        def search_by_condition(args)
          refresh
          attr = args[:attr]
          oper  = args[:oper]
          value = args[:value]
Severity: Minor
Found in lib/hawatel_ps/linux/proc_table.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method process_files has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        def process_files(attrs, sockets)
          fd_dir  = "/proc/#{attrs[:pid]}/fd"
          files   = Array.new
          ports   = Array.new
          if File.readable?(fd_dir)
Severity: Minor
Found in lib/hawatel_ps/linux/proc_fetch.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for search_by_condition is too high. [14/10]
Open

        def search_by_condition(args)
          find_all

          attrs = args[:attr]
          oper  = args[:oper]
Severity: Minor
Found in lib/hawatel_ps/windows/proc_table.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method process_limits has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

        def process_limits(pid)
          limits_file = "/proc/#{pid}/limits"
          limits_list = Array.new
          if File.readable?(limits_file)
            File.foreach(limits_file).each do |line|
Severity: Minor
Found in lib/hawatel_ps/linux/proc_fetch.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for process_status is too high. [12/10]
Open

        def process_status(attrs)
          status_file = "/proc/#{attrs[:pid]}/status"
          File.foreach(status_file).each do |attr|
            if attr =~ /Name:/
              attrs[:name] = attr.split(' ')[1]
Severity: Minor
Found in lib/hawatel_ps/linux/proc_fetch.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method process_status has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

        def process_status(attrs)
          status_file = "/proc/#{attrs[:pid]}/status"
          File.foreach(status_file).each do |attr|
            if attr =~ /Name:/
              attrs[:name] = attr.split(' ')[1]
Severity: Minor
Found in lib/hawatel_ps/linux/proc_fetch.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_status has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def process_status(attrs)
          status_file = "/proc/#{attrs[:pid]}/status"
          File.foreach(status_file).each do |attr|
            if attr =~ /Name:/
              attrs[:name] = attr.split(' ')[1]
Severity: Minor
Found in lib/hawatel_ps/linux/proc_fetch.rb - About 1 hr to fix

    Method search_by_name has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

            def search_by_name(process_name)
          if process_name =~ /^\/.*\/$/
            process_name.slice!(0)
            process_name = Regexp.new(/#{process_name.chop}/)
            find_all
    Severity: Minor
    Found in lib/hawatel_ps/windows/proc_table.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      class HawatelPSException < Exception
    # Custom exception
    # @param args [Hash] the options to create a custom exception message
    # @option :exception [Exception] Native Exception object
    # @option :message [String] Custom message
    Severity: Major
    Found in lib/hawatel_ps/shared/hawatelps_exception.rb and 1 other location - About 1 hr to fix
    lib/hawatel_ps/windows/wmi/wmi_exception.rb on lines 5..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        class WmiCliException < Exception
      # Custom exception
      # @param args [Hash] the options to create a custom exception message
      # @option :exception [Exception] Native Exception object
      # @option :message [String] Custom message
    Severity: Major
    Found in lib/hawatel_ps/windows/wmi/wmi_exception.rb and 1 other location - About 1 hr to fix
    lib/hawatel_ps/shared/hawatelps_exception.rb on lines 4..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method process_limits has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def process_limits(pid)
          limits_file = "/proc/#{pid}/limits"
          limits_list = Array.new
          if File.readable?(limits_file)
            File.foreach(limits_file).each do |line|
    Severity: Minor
    Found in lib/hawatel_ps/linux/proc_fetch.rb - About 1 hr to fix

      Method search_by_name has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

              def search_by_name(process_name)
          refresh
          process_list = Array.new
          if process_name =~ /^\/.*\/$/
            process_name.slice!(0)
      Severity: Minor
      Found in lib/hawatel_ps/linux/proc_table.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                    process_list << process if process[:"#{attr}"] <= value if process[:"#{attr}"]
      Severity: Major
      Found in lib/hawatel_ps/linux/proc_table.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                      process_list << process if process[:"#{attrs}"] <= value
        Severity: Major
        Found in lib/hawatel_ps/windows/proc_table.rb - About 45 mins to fix

          Method prepare_wql has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def prepare_wql(query, args = nil)
          if args.nil?
            return query
          else
            query += " WHERE "
          Severity: Minor
          Found in lib/hawatel_ps/windows/proc_fetch.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                        process_list << process if process[:"#{attr}"] >= value if process[:"#{attr}"]
          Severity: Major
          Found in lib/hawatel_ps/linux/proc_table.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        elsif oper == '=='
              process_list << process if process[:"#{attrs}"] == value
            elsif oper == '!='
              process_list << process if process[:"#{attrs}"] != value
            Severity: Major
            Found in lib/hawatel_ps/windows/proc_table.rb - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          elsif oper == '=='
              process_list << process if process[:"#{attr}"] == value if process[:"#{attr}"]
            elsif oper == '!='
              process_list << process if process[:"#{attr}"] != value if process[:"#{attr}"]
              Severity: Major
              Found in lib/hawatel_ps/linux/proc_table.rb - About 45 mins to fix
                Severity
                Category
                Status
                Source
                Language