HaxeCheckstyle/haxe-checkstyle

View on GitHub

Showing 4 of 4 total issues

Method checkClass length is 53 lines (max allowed is 50)
Open

    function checkClass(emptyLines:ListOfEmptyLines, typeToken:TokenTree) {
        var places:Array<EmptyLinesPlace> = [
            BEGIN_CLASS,
            END_CLASS,
            BETWEEN_CLASS_METHODS,

Checks for long methods. If a method becomes very long it is hard to understand. Therefore long methods should usually be refactored into several individual methods that focus on a specific task.

Method actualRun length is 51 lines (max allowed is 50)
Open

    override function actualRun() {
        var root:TokenTree = checker.getTokenTree();
        var acceptableTokens:Array<TokenTree> = root.filterCallback(function(token:TokenTree, depth:Int):FilterResult {
            return switch (token.tok) {
                case Kwd(KwdIf), Kwd(KwdFor), Kwd(KwdWhile), Kwd(KwdSwitch), Kwd(KwdCatch):

Checks for long methods. If a method becomes very long it is hard to understand. Therefore long methods should usually be refactored into several individual methods that focus on a specific task.

Method actualRun length is 51 lines (max allowed is 50)
Open

    override function actualRun() {
        var classes:Array<TokenTree> = findClasses();
        for (cls in classes) {
            if (extendsBaseClass(cls)) continue;
            if (isPosSuppressed(cls.pos)) continue;

Checks for long methods. If a method becomes very long it is hard to understand. Therefore long methods should usually be refactored into several individual methods that focus on a specific task.

COMMENTED_OUT_CODE modifier order is invalid (modifier: FINAL)
Open

    static inline final COMMENTED_OUT_CODE:String = "This block of commented-out lines of code should be removed";

Checks that the order of modifiers conforms to the standards.

Severity
Category
Status
Source
Language