Showing 243 of 243 total issues
Method processNode
is too complex (score: 20). Open
static function processNode(xml:Xml):Void {
if (xml.nodeType == Xml.Element) {
switch (xml.nodeName) {
case "a":
if (xml.exists("href")) {
- Read upRead up
- Exclude checks
Checks the complexity of methods using McCabe simplified cyclomatic complexity check. Complexity levels can be customised using thresholds
property.
TODO comment:TODO: for now uses curl, haxe.Http in https doesn't work in --interp, and in neko it doesn't work ssl@ssl_recv
Open
//TODO: for now uses curl, haxe.Http in https doesn't work in --interp, and in neko it doesn't work "ssl@ssl_recv"
- Read upRead up
- Exclude checks
A check for TODO/FIXME/HACK/XXX/BUG comments. The format can be customised by changing format
property.
TODO comment:TODO: make something a little less horrible here Open
//TODO: make something a little less horrible here
- Read upRead up
- Exclude checks
A check for TODO/FIXME/HACK/XXX/BUG comments. The format can be customised by changing format
property.
Nested loop depth is 2 (max allowed is 1) Open
for (i in 0 ... category.videos.length) {
var video = category.videos[i];
video.prev = category.videos[i - 1];
video.next = category.videos[i + 1];
}
- Read upRead up
- Exclude checks
Restricts nested loop blocks to a specified depth (default = 1).
Nested loop depth is 2 (max allowed is 1) Open
while (category.featuredVideos.length < 5 && category.videos.length >= 5) {
var v = category.videos[i++];
if (category.featuredVideos.indexOf(v) < 0) category.featuredVideos.push(v);
if (category.userFeaturedVideos.indexOf(v) < 0) category.userFeaturedVideos.push(v);
}
- Read upRead up
- Exclude checks
Restricts nested loop blocks to a specified depth (default = 1).
TODO comment: TODO: figure out where is lf-markup... Open
// TODO: figure out where is lf-markup...
- Read upRead up
- Exclude checks
A check for TODO/FIXME/HACK/XXX/BUG comments. The format can be customised by changing format
property.
Anonymous structure data
found, use typedef
Open
var data:{ title:String, description:String, videos:Array<Video>} = Json.parse(File.getContent(path));
- Read upRead up
- Exclude checks
Check to find any anonymous type structures used.
Nested loop depth is 2 (max allowed is 1) Open
for (video in category.videos) {
totalVideos ++;
Utils.save(Path.join([Config.outputFolder, video.path]), Views.VideoPage(
video,
section.categories,
- Read upRead up
- Exclude checks
Restricts nested loop blocks to a specified depth (default = 1).
Too many parameters for function: MainLayout (> 7) Open
@:template public static function MainLayout (title:String, description:String, navBar:Html, viewContent:Html, siteMap:Html, currentYear:String, editLink:String, additionalScripts:Html, additionalStyles:Html) : Html;
- Read upRead up
- Exclude checks
Checks the number of parameters of a method.
Too many parameters for function: save (> 7) Open
public static function save(outPath:String, content:String, current:SiteMap.SitePage, editLink:String, title:String = null, description:String = null, additionalScripts:String = null,additionalStyles:String = null) {
var dir = Path.directory(outPath);
if (!FileSystem.exists(dir)) {
FileSystem.createDirectory(dir);
}
- Read upRead up
- Exclude checks
Checks the number of parameters of a method.
Inner assignment detected Open
downloads.linux.archives.push(current = getInfo("Linux 64-bit Binaries", url));
- Read upRead up
- Exclude checks
Checks for assignments in subexpressions, such as in if ((a=b) > 0) return;
.
Too many parameters for function: DownloadVersion (> 7) Open
@:template public static function DownloadVersion (version:DownloadsData.Version, prev:String, next:String, title:String, downloads:DownloadsData.DownloadList, current:String, releaseNotes:Html, changes:Html, prevTag:String) : Html;
- Read upRead up
- Exclude checks
Checks the number of parameters of a method.
Too many parameters for function: BlogPost (> 7) Open
@:template public static function BlogPost (background:String, title:String, description:String, authors:Array<generators.Blog.Author>, name:String, date:String, disqusID:String, content:Html, tags:Array<{ name:String }>) : Html;
- Read upRead up
- Exclude checks
Checks the number of parameters of a method.
Inner assignment detected Open
downloads.linux.archives.unshift(current = getInfo("Linux 32-bit Binaries", url));
- Read upRead up
- Exclude checks
Checks for assignments in subexpressions, such as in if ((a=b) > 0) return;
.
Inner assignment detected Open
downloads.linux.archives.push(current = getInfo("Raspberry Pi", url));
- Read upRead up
- Exclude checks
Checks for assignments in subexpressions, such as in if ((a=b) > 0) return;
.
Parameter definition of posts
masks member of same name Open
static function genRss (posts:Array<Post>) {
- Read upRead up
- Exclude checks
Checks that a local variable or a parameter does not shadow a field that is defined in the same class.
Inner assignment detected Open
downloads.osx.installers.unshift(current = getInfo("OS X Installer", url));
- Read upRead up
- Exclude checks
Checks for assignments in subexpressions, such as in if ((a=b) > 0) return;
.
Inner assignment detected Open
downloads.windows.installers.unshift(current = getInfo("Windows 64-bit Installer", url));
- Read upRead up
- Exclude checks
Checks for assignments in subexpressions, such as in if ((a=b) > 0) return;
.
Inner assignment detected Open
downloads.osx.archives.push(current = getInfo("OS X Binaries", url));
- Read upRead up
- Exclude checks
Checks for assignments in subexpressions, such as in if ((a=b) > 0) return;
.
Inner assignment detected Open
downloads.windows.installers.push(current = getInfo("Windows 32-bit Installer", url));
- Read upRead up
- Exclude checks
Checks for assignments in subexpressions, such as in if ((a=b) > 0) return;
.