Sign upLogin

HazyResearch/numbskull

View on GitHub
Star
numbskull/distributed.py

Summary

Maintainability
D
2 days
Test Coverage

Function server has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

def server(argv=None):
    """TODO."""
    parser = argparse.ArgumentParser(
        description="Run Gibbs worker",
        epilog="")
Severity: Minor
Found in numbskull/distributed.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File distributed.py has 308 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python

"""TODO."""

from __future__ import print_function
Severity: Minor
Found in numbskull/distributed.py - About 3 hrs to fix

    Cyclomatic complexity is too high in function client. (13)
    Open

    def client(argv=None):
    """TODO."""
    parser = argparse.ArgumentParser(
        description="Run Gibbs worker",
        epilog="")
    Severity: Minor
    Found in numbskull/distributed.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in function server. (13)
    Open

    def server(argv=None):
    """TODO."""
    parser = argparse.ArgumentParser(
        description="Run Gibbs worker",
        epilog="")
    Severity: Minor
    Found in numbskull/distributed.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function client has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    def client(argv=None):
    """TODO."""
    parser = argparse.ArgumentParser(
        description="Run Gibbs worker",
        epilog="")
    Severity: Minor
    Found in numbskull/distributed.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity is too high in function main. (7)
    Open

    def main(argv=None):
    """TODO."""
    if argv is None:
        argv = sys.argv[1:]
    Severity: Minor
    Found in numbskull/distributed.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function client has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def client(argv=None):
    """TODO."""
    parser = argparse.ArgumentParser(
        description="Run Gibbs worker",
        epilog="")
    Severity: Minor
    Found in numbskull/distributed.py - About 1 hr to fix

      Function send_array has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def send_array(socket, A, flags=0, copy=True, track=False):
      Severity: Minor
      Found in numbskull/distributed.py - About 35 mins to fix

        Function main has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def main(argv=None):
    """TODO."""
    if argv is None:
        argv = sys.argv[1:]
        Severity: Minor
        Found in numbskull/distributed.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        TODO found
        Open

            # TODO: sample observed variable option
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

            """TODO."""
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

            """TODO."""
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

                    # TODO: check that fg != None
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

            """TODO."""
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

            # TODO: print default for meta, weight, variable, factor in help
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

                    # TODO
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

            """TODO: recv a numpy array."""
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

        """TODO."""
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

            # TODO: barrier between burn, learn, and inference
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

                    # TODO: handle count
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

                        socket.send_json(0.001, zmq.SNDMORE)  # TODO
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

            """TODO: send a numpy array with metadata."""
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

            # TODO: print default for meta, weight, variable, factor in help
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

            # TODO: verbose option (print all info)
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        TODO found
        Open

                    # TODO: could just not send SNDMORE for last arg
        Severity: Minor
        Found in numbskull/distributed.py by fixme

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                (meta, weight, variable, factor,
         fstart, fmap, vstart, vmap, equalPredicate) = \
            gibbs.load(arg.directory, arg.meta, arg.weight, arg.variable,
                       arg.factor, not arg.quiet, not arg.verbose)
        Severity: Major
        Found in numbskull/distributed.py and 1 other location - About 1 hr to fix
        numbskull/distributed.py on lines 273..276

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                (meta, weight, variable, factor,
         fstart, fmap, vstart, vmap, equalPredicate) = \
            gibbs.load(arg.directory, arg.meta, arg.weight, arg.variable,
                       arg.factor, not arg.quiet, not arg.verbose)
        Severity: Major
        Found in numbskull/distributed.py and 1 other location - About 1 hr to fix
        numbskull/distributed.py on lines 130..133

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            elif argv[0].lower() == "server" or argv[0].lower() == "s":
        Severity: Major
        Found in numbskull/distributed.py and 1 other location - About 1 hr to fix
        numbskull/distributed.py on lines 367..367

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            elif argv[0].lower() == "client" or argv[0].lower() == "c":
        Severity: Major
        Found in numbskull/distributed.py and 1 other location - About 1 hr to fix
        numbskull/distributed.py on lines 365..365

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 38.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status