HazyResearch/numbskull

View on GitHub
salt/src/numbskull_minion_server.py

Summary

Maintainability
F
3 days
Test Coverage

Function _set_tcp_keepalive has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

def _set_tcp_keepalive(sock, opts):
    """Ensure that TCP keepalives are set for the socket."""
    if hasattr(socket, 'SO_KEEPALIVE'):
        if opts.get('tcp_keepalive', False):
            sock.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)
Severity: Minor
Found in salt/src/numbskull_minion_server.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File numbskull_minion_server.py has 419 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""TODO."""

# Import python libs
from __future__ import absolute_import
import logging
Severity: Minor
Found in salt/src/numbskull_minion_server.py - About 6 hrs to fix

    Cyclomatic complexity is too high in function _set_tcp_keepalive. (15)
    Open

    def _set_tcp_keepalive(sock, opts):
        """Ensure that TCP keepalives are set for the socket."""
        if hasattr(socket, 'SO_KEEPALIVE'):
            if opts.get('tcp_keepalive', False):
                sock.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)
    Severity: Minor
    Found in salt/src/numbskull_minion_server.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in method __bind. (8)
    Open

        def __bind(self):
            """TODO."""
            if self.log_queue is not None:
                salt.log.setup.set_multiprocessing_logging_queue(self.log_queue)
            salt.log.setup.setup_multiprocessing_logging(self.log_queue)
    Severity: Minor
    Found in salt/src/numbskull_minion_server.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in method handle_stream. (6)
    Open

        @tornado.gen.coroutine
        def handle_stream(self, stream, address):
            """Handle incoming streams and add messages to the incoming queue."""
            self.log.debug('InfLearn client {0} connected'.format(address))
            self.clients.append((stream, address))
    Severity: Minor
    Found in salt/src/numbskull_minion_server.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            def run(self):
                """Start the load balancer."""
                self._socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
                self._socket.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
                _set_tcp_keepalive(self._socket, self.opts)
    Severity: Minor
    Found in salt/src/numbskull_minion_server.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if tcp_keepalive_idle > 0:
                            sock.setsockopt(
                                socket.SOL_TCP, socket.TCP_KEEPIDLE,
                                int(tcp_keepalive_idle))
                    if hasattr(socket, 'TCP_KEEPCNT'):
    Severity: Major
    Found in salt/src/numbskull_minion_server.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if tcp_keepalive_idle <= 0:
                              tcp_keepalive_idle = 7200
                          if tcp_keepalive_intvl <= 0:
      Severity: Major
      Found in salt/src/numbskull_minion_server.py - About 45 mins to fix

        Function handle_stream has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def handle_stream(self, stream, address):
                """Handle incoming streams and add messages to the incoming queue."""
                self.log.debug('InfLearn client {0} connected'.format(address))
                self.clients.append((stream, address))
                unpacker = msgpack.Unpacker()
        Severity: Minor
        Found in salt/src/numbskull_minion_server.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                            if tcp_keepalive_intvl > 0:
                                sock.setsockopt(
                                    socket.SOL_TCP, socket.TCP_KEEPINTVL,
                                    int(tcp_keepalive_intvl))
                    if hasattr(socket, 'SIO_KEEPALIVE_VALS'):
        Severity: Major
        Found in salt/src/numbskull_minion_server.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if tcp_keepalive_intvl <= 0:
                                  tcp_keepalive_intvl = 1
                              # The values expected are in milliseconds, so multiply by
                              # 1000.
                              sock.ioctl(socket.SIO_KEEPALIVE_VALS, (
          Severity: Major
          Found in salt/src/numbskull_minion_server.py - About 45 mins to fix

            Function __bind has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def __bind(self):
                    """TODO."""
                    if self.log_queue is not None:
                        salt.log.setup.set_multiprocessing_logging_queue(self.log_queue)
                    salt.log.setup.setup_multiprocessing_logging(self.log_queue)
            Severity: Minor
            Found in salt/src/numbskull_minion_server.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                if tcp_keepalive_cnt > 0:
                                    sock.setsockopt(
                                        socket.SOL_TCP, socket.TCP_KEEPCNT,
                                        int(tcp_keepalive_cnt))
                            if hasattr(socket, 'TCP_KEEPINTVL'):
            Severity: Major
            Found in salt/src/numbskull_minion_server.py - About 45 mins to fix

              Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def __init__(self,
              Severity: Minor
              Found in salt/src/numbskull_minion_server.py - About 35 mins to fix

                Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def __init__(self, socket_queue, message_handler, logger, *args,
                Severity: Minor
                Found in salt/src/numbskull_minion_server.py - About 35 mins to fix

                  Function close has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def close(self):
                          """TODO."""
                          if self._socket is not None:
                              try:
                                  self._socket.shutdown(socket.SHUT_RDWR)
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function handle_message has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def handle_message(self, stream, header, payload):
                          """Handle incoming messages from underylying tcp streams."""
                          if self.fire_local_event(payload):
                              try:
                                  stream.write(salt.transport.frame.frame_msg('OK',
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  TODO found
                  Open

                              """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                              """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                              """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                      """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                  """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                              """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                              """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                              """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          # TODO: opts!
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                      """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                              """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                      """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          """TODO."""
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          TODO.
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  TODO found
                  Open

                          TODO.
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py by fixme

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                                  if hasattr(socket, 'TCP_KEEPINTVL'):
                                      tcp_keepalive_intvl = opts.get('tcp_keepalive_intvl', -1)
                                      if tcp_keepalive_intvl > 0:
                                          sock.setsockopt(
                                              socket.SOL_TCP, socket.TCP_KEEPINTVL,
                  Severity: Major
                  Found in salt/src/numbskull_minion_server.py and 2 other locations - About 2 hrs to fix
                  salt/src/numbskull_minion_server.py on lines 65..70
                  salt/src/numbskull_minion_server.py on lines 71..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                                  if hasattr(socket, 'TCP_KEEPCNT'):
                                      tcp_keepalive_cnt = opts.get('tcp_keepalive_cnt', -1)
                                      if tcp_keepalive_cnt > 0:
                                          sock.setsockopt(
                                              socket.SOL_TCP, socket.TCP_KEEPCNT,
                  Severity: Major
                  Found in salt/src/numbskull_minion_server.py and 2 other locations - About 2 hrs to fix
                  salt/src/numbskull_minion_server.py on lines 65..70
                  salt/src/numbskull_minion_server.py on lines 77..82

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                                  if hasattr(socket, 'TCP_KEEPIDLE'):
                                      tcp_keepalive_idle = opts.get('tcp_keepalive_idle', -1)
                                      if tcp_keepalive_idle > 0:
                                          sock.setsockopt(
                                              socket.SOL_TCP, socket.TCP_KEEPIDLE,
                  Severity: Major
                  Found in salt/src/numbskull_minion_server.py and 2 other locations - About 2 hrs to fix
                  salt/src/numbskull_minion_server.py on lines 71..76
                  salt/src/numbskull_minion_server.py on lines 77..82

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if self.fire_local_event(payload):
                              try:
                                  stream.write(salt.transport.frame.frame_msg('OK',
                                                                              header=header))
                              except:
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py and 1 other location - About 55 mins to fix
                  salt/src/numbskull_minion_server.py on lines 368..379

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 37.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              self._socket.bind((self.opts['inf_learn_interface'],
                                                 int(self.opts['inf_learn_port'])))
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py and 1 other location - About 40 mins to fix
                  salt/src/numbskull_minion_server.py on lines 330..331

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 34.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              self._socket.bind((self._opts['inf_learn_interface'],
                                                 int(self._opts['inf_learn_port'])))
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py and 1 other location - About 40 mins to fix
                  salt/src/numbskull_minion_server.py on lines 170..171

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 34.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      def __init__(self, opts, logger, salt, log_queue=None):
                          """TODO."""
                          self.opts = opts
                          self.log_queue = log_queue
                          self.log = logger
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py and 1 other location - About 30 mins to fix
                  salt/src/numbskull_minion_server.py on lines 286..291

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 32.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      def __init__(self, logger, opts, salt):
                          """TODO."""
                          self.log = logger
                          self._opts = opts
                          self._socket = None
                  Severity: Minor
                  Found in salt/src/numbskull_minion_server.py and 1 other location - About 30 mins to fix
                  salt/src/numbskull_minion_server.py on lines 385..390

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 32.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status