Hennessy811/react-app-boilerplate

View on GitHub

Showing 7 of 31 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        catchError(error => {
          const message = JSON.parse(JSON.stringify(error)).message || 'Неизвестная ошибка';
          return of({
            type: TodosActions.GetTodosListError,
            payload: { error: message },
Severity: Major
Found in src/store/Todos/todos.effect.ts and 1 other location - About 1 hr to fix
src/store/Todos/todos.effect.ts on lines 39..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        catchError(error => {
          const message = JSON.parse(JSON.stringify(error)).message || 'Неизвестная ошибка';
          return of({
            type: TodosActions.CreateNewTodoError,
            payload: { error: message },
Severity: Major
Found in src/store/Todos/todos.effect.ts and 1 other location - About 1 hr to fix
src/store/Todos/todos.effect.ts on lines 18..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function Todos has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Todos: FC = () => {
  const dispatch = useDispatch();

  const [isModalVisible, setIsModalVisible] = useState(false);
  const [todoObject, setTodoObject] = useState(todoObj);
Severity: Minor
Found in src/scenes/Todos/Todos.tsx - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const selectTodoTypeOptions: Option[] = [
      {
        title: 'Изи',
        value: 'easy',
      },
    Severity: Major
    Found in src/scenes/Todos/Todos.tsx and 1 other location - About 1 hr to fix
    src/scenes/Todos/Todos.tsx on lines 28..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const selectTodoSourceOptions: Option[] = [
      {
        title: 'GitHub',
        value: 'github',
      },
    Severity: Major
    Found in src/scenes/Todos/Todos.tsx and 1 other location - About 1 hr to fix
    src/scenes/Todos/Todos.tsx on lines 46..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function getToken has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const getToken = () => {
      // Получаем токен из LocalStorage
      const localToken: Tokens = JSON.parse(localStorage.getItem('token') || 'null');
    
      // Если токена нет локально, то получаем его
    Severity: Minor
    Found in src/store/restClient.ts - About 1 hr to fix

      Function App has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const App: React.FC = () => {
        const dispatch = useDispatch();
      
        useEffect(() => {
          // dispatch({ type: BalanceActions.GetBalance });
      Severity: Minor
      Found in src/App.tsx - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language