Sign upLogin

HerbCSO/ticketeer

View on GitHub
Star

Showing 292 of 292 total issues

Avoid too many return statements within this function.
Open

      return ret.getTime() + parseInt(p[2], 10) * 604800000;
Severity: Major
Found in app/assets/javascripts/morris.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return new Date(parseInt(r[1], 10), parseInt(r[2], 10) - 1, parseInt(r[3], 10), parseInt(r[4], 10), parseInt(r[5], 10), isecs, msecs).getTime();
    Severity: Major
    Found in app/assets/javascripts/morris.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return new Date(parseInt(q[1], 10), parseInt(q[2], 10) - 1, parseInt(q[3], 10), parseInt(q[4], 10), parseInt(q[5], 10)).getTime();
      Severity: Major
      Found in app/assets/javascripts/morris.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    t2 = (-b - math.sqrt(b * b - 4 * a * c)) / 2 / a;
        Severity: Minor
        Found in app/assets/javascripts/raphael.js and 1 other location - About 30 mins to fix
        app/assets/javascripts/raphael.js on lines 2336..2336

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                return boundaryOption;
        Severity: Major
        Found in app/assets/javascripts/morris.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return Date.UTC(parseInt(q[1], 10), parseInt(q[2], 10) - 1, parseInt(q[3], 10), parseInt(q[4], 10), parseInt(q[5], 10) + offsetmins);
          Severity: Major
          Found in app/assets/javascripts/morris.js - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (deg.length - 1) {
            cx = toFloat(deg[1]);
            cy = toFloat(deg[2]);
        }
            Severity: Minor
            Found in app/assets/javascripts/raphael.js and 1 other location - About 30 mins to fix
            app/assets/javascripts/raphael.js on lines 7637..7640

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                    return Date.UTC(parseInt(r[1], 10), parseInt(r[2], 10) - 1, parseInt(r[3], 10), parseInt(r[4], 10), parseInt(r[5], 10) + offsetmins, isecs, msecs);
            Severity: Major
            Found in app/assets/javascripts/morris.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return new Date(parseInt(date, 10), 0, 1).getTime();
              Severity: Major
              Found in app/assets/javascripts/morris.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                          return parseInt(boundaryOption, 10);
                Severity: Major
                Found in app/assets/javascripts/morris.js - About 30 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (deg.length - 1) {
            cx = toFloat(deg[1]);
            cy = toFloat(deg[2]);
        }
                  Severity: Minor
                  Found in app/assets/javascripts/raphael.js and 1 other location - About 30 mins to fix
                  app/assets/javascripts/raphael.js on lines 6475..6478

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method generate_reply has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def generate_reply(message_input)
    Random.new
    message = message_input.downcase
    bad_clients = ["ngma","cms","tru"]
    probably_no = ["is it possible to","do you think we can","the client asked if we could","is it feasible to","can we","should we","can i","should i"]
                  Severity: Minor
                  Found in app/controllers/messages_controller.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language