HewlettPackard/oneview-sdk-ruby

View on GitHub
lib/oneview-sdk/resource/api200/logical_switch.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method generate_logical_switch_credentials has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def generate_logical_switch_credentials
        credentials = []
        @logical_switch_credentials.each_value do |switch|
          switch_credentials = []
          switch_credentials << {
Severity: Minor
Found in lib/oneview-sdk/resource/api200/logical_switch.rb - About 1 hr to fix

    Method generate_logical_switch_credential_configuration has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def generate_logical_switch_credential_configuration
            configuration = []
            @logical_switch_credentials.each do |host, switch|
              switch_configuration = {
                'snmpPort' => switch[1].port,
    Severity: Minor
    Found in lib/oneview-sdk/resource/api200/logical_switch.rb - About 1 hr to fix

      Method generate_logical_switch_credential_configuration has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def generate_logical_switch_credential_configuration
              configuration = []
              @logical_switch_credentials.each do |host, switch|
                switch_configuration = {
                  'snmpPort' => switch[1].port,
      Severity: Minor
      Found in lib/oneview-sdk/resource/api200/logical_switch.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status