HewlettPackard/oneview-sdk-ruby

View on GitHub
lib/oneview-sdk/resource/api300/c7000/enclosure_group.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method add_lig_to_bay has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def add_lig_to_bay(bay, lig, enclosureIndex)
          @data['interconnectBayMappings'].each do |location|
            next unless location['interconnectBay'] == bay
            if enclosureIndex
              next unless location['enclosureIndex'] == enclosureIndex
Severity: Minor
Found in lib/oneview-sdk/resource/api300/c7000/enclosure_group.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method add_logical_interconnect_group has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        def add_logical_interconnect_group(lig, enclosureIndex = nil)
          lig.retrieve! unless lig['uri']
          raise(NotFound, "The logical interconnect group #{lig['name']} was not found") unless lig['uri']
          lig['interconnectMapTemplate']['interconnectMapEntryTemplates'].each do |entry|
            entry['logicalLocation']['locationEntries'].each do |location|
Severity: Minor
Found in lib/oneview-sdk/resource/api300/c7000/enclosure_group.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status