HipByte/codeclimate-rubymotion

View on GitHub

Showing 56 of 56 total issues

Assignment Branch Condition size for run is too high. [17.15/15]
Open

      def run
        Dir.chdir(@directory) do
          Dir["**/*.rb"].each do |path|
            parsed = RuboCop::ProcessedSource.new(File.read(path), path)

Severity: Minor
Found in lib/cc/engine/rubymotion.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for on_method_def is too high. [16.58/15]
Open

        def on_method_def(_node, _method_name, _args, body)
          return unless _method_name == :init
          return unless body
          return if body.self_type?

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method on_method_def has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        def on_method_def(_node, _method_name, _args, body)
          return unless _method_name == :init
          return unless body
          return if body.self_type?

Severity: Minor
Found in lib/rubocop/cop/rubymotion/init_must_return_self.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return if last_expr_in_body.return_type? && last_expr_in_body.children.last.self_type?
Severity: Major
Found in lib/rubocop/cop/rubymotion/init_must_return_self.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

              return if last_expr_in_body.self_type?
    Severity: Major
    Found in lib/rubocop/cop/rubymotion/init_must_return_self.rb - About 30 mins to fix

      Space found before comma.
      Open

            def initialize(directory: , io: , engine_config: )
      Severity: Minor
      Found in lib/cc/engine/rubymotion.rb by rubocop

      Checks for comma (,) preceded by space.

      Example:

      # bad
      [1 , 2 , 3]
      a(1 , 2)
      each { |a , b| }
      
      # good
      [1, 2, 3]
      a(1, 2)
      each { |a, b| }

      Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
      Open

      require 'rubocop/cop/rubymotion/dealloc_must_call_super'
      Severity: Minor
      Found in lib/cc/rubymotion_cops.rb by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
      "No special symbols"
      "No string interpolation"
      "Just text"
      
      # good
      'No special symbols'
      'No string interpolation'
      'Just text'
      "Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
      'Just some text'
      'No special chars or interpolation'
      
      # good
      "Just some text"
      "No special chars or interpolation"
      "Every string in #{project} uses double_quotes"

      Use the new Ruby 1.9 hash syntax.
      Open

      gem "rubocop", :git => 'https://github.com/mrb/rubocop.git', :ref => 'c4b6ae4c323172c81e0f8f18f54e4e36a03b73d1'
      Severity: Minor
      Found in Gemfile by rubocop

      This cop checks hash literal syntax.

      It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

      A separate offense is registered for each problematic pair.

      The supported styles are:

      • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
      • hash_rockets - forces use of hash rockets for all hashes
      • nomixedkeys - simply checks for hashes with mixed syntaxes
      • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

      Example: EnforcedStyle: ruby19 (default)

      # bad
      {:a => 2}
      {b: 1, :c => 2}
      
      # good
      {a: 2, b: 1}
      {:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
      {d: 1, 'e' => 2} # technically not forbidden

      Example: EnforcedStyle: hash_rockets

      # bad
      {a: 1, b: 2}
      {c: 1, 'd' => 5}
      
      # good
      {:a => 1, :b => 2}

      Example: EnforcedStyle: nomixedkeys

      # bad
      {:a => 1, b: 2}
      {c: 1, 'd' => 2}
      
      # good
      {:a => 1, :b => 2}
      {c: 1, d: 2}

      Example: EnforcedStyle: ruby19nomixed_keys

      # bad
      {:a => 1, :b => 2}
      {c: 2, 'd' => 3} # should just use hash rockets
      
      # good
      {a: 1, b: 2}
      {:c => 3, 'd' => 4}

      Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
      Open

      source 'https://rubygems.org'
      Severity: Minor
      Found in Gemfile by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
      "No special symbols"
      "No string interpolation"
      "Just text"
      
      # good
      'No special symbols'
      'No string interpolation'
      'Just text'
      "Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
      'Just some text'
      'No special chars or interpolation'
      
      # good
      "Just some text"
      "No special chars or interpolation"
      "Every string in #{project} uses double_quotes"

      Line is too long. [81/80]
      Open

      $LOAD_PATH.unshift(File.expand_path(File.join(File.dirname(__FILE__), "../lib")))
      Severity: Minor
      Found in bin/codeclimate-rubymotion by rubocop

      Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
      Open

      require 'cc/engine/rubymotion'
      Severity: Minor
      Found in bin/codeclimate-rubymotion by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
      "No special symbols"
      "No string interpolation"
      "Just text"
      
      # good
      'No special symbols'
      'No string interpolation'
      'Just text'
      "Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
      'Just some text'
      'No special chars or interpolation'
      
      # good
      "Just some text"
      "No special chars or interpolation"
      "Every string in #{project} uses double_quotes"

      Space between { and | missing.
      Open

                if body.each_node.none?{|x| x.type == :self }

      Checks that block braces have or don't have surrounding space inside them on configuration. For blocks taking parameters, it checks that the left brace has or doesn't have trailing space depending on configuration.

      Example: EnforcedStyle: space (default)

      # The `space` style enforces that block braces have
      # surrounding space.
      
      # bad
      some_array.each {puts e}
      
      # good
      some_array.each { puts e }

      Example: EnforcedStyle: no_space

      # The `no_space` style enforces that block braces don't
      # have surrounding space.
      
      # bad
      some_array.each { puts e }
      
      # good
      some_array.each {puts e}

      Example: EnforcedStyleForEmptyBraces: no_space (default)

      # The `no_space` EnforcedStyleForEmptyBraces style enforces that
      # block braces don't have a space in between when empty.
      
      # bad
      some_array.each {   }
      some_array.each {  }
      some_array.each { }
      
      # good
      some_array.each {}

      Example: EnforcedStyleForEmptyBraces: space

      # The `space` EnforcedStyleForEmptyBraces style enforces that
      # block braces have at least a spece in between when empty.
      
      # bad
      some_array.each {}
      
      # good
      some_array.each { }
      some_array.each {  }
      some_array.each {   }

      Example: SpaceBeforeBlockParameters: true (default)

      # The SpaceBeforeBlockParameters style set to `true` enforces that
      # there is a space between `{` and `|`. Overrides `EnforcedStyle`
      # if there is a conflict.
      
      # bad
      [1, 2, 3].each {|n| n * 2 }
      
      # good
      [1, 2, 3].each { |n| n * 2 }

      Example: SpaceBeforeBlockParameters: true

      # The SpaceBeforeBlockParameters style set to `false` enforces that
      # there is no space between `{` and `|`. Overrides `EnforcedStyle`
      # if there is a conflict.
      
      # bad
      [1, 2, 3].each { |n| n * 2 }
      
      # good
      [1, 2, 3].each {|n| n * 2 }

      Freeze mutable objects assigned to constants.
      Open

              MESSAGE = "When overriding the #init method, self must be returned."

      This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

      Example:

      # bad
      CONST = [1, 2, 3]
      
      # good
      CONST = [1, 2, 3].freeze

      Extra empty line detected at class body beginning.
      Open

      
              MESSAGE = "Do not use retainCount"

      This cops checks if empty lines around the bodies of classes match the configuration.

      Example: EnforcedStyle: empty_lines

      # good
      
      class Foo
      
        def bar
          # ...
        end
      
      end

      Example: EnforcedStyle: emptylinesexcept_namespace

      # good
      
      class Foo
        class Bar
      
          # ...
      
        end
      end

      Example: EnforcedStyle: emptylinesspecial

      # good
      class Foo
      
        def bar; end
      
      end

      Example: EnforcedStyle: noemptylines (default)

      # good
      
      class Foo
        def bar
          # ...
        end
      end

      Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
      Open

      require 'rubocop'
      Severity: Minor
      Found in lib/cc/engine/rubymotion.rb by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
      "No special symbols"
      "No string interpolation"
      "Just text"
      
      # good
      'No special symbols'
      'No string interpolation'
      'Just text'
      "Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
      'Just some text'
      'No special chars or interpolation'
      
      # good
      "Just some text"
      "No special chars or interpolation"
      "Every string in #{project} uses double_quotes"

      Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
      Open

      require 'cc/rubymotion_cops'
      Severity: Minor
      Found in lib/cc/engine/rubymotion.rb by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
      "No special symbols"
      "No string interpolation"
      "Just text"
      
      # good
      'No special symbols'
      'No string interpolation'
      'Just text'
      "Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
      'Just some text'
      'No special chars or interpolation'
      
      # good
      "Just some text"
      "No special chars or interpolation"
      "Every string in #{project} uses double_quotes"

      Indent the right bracket the same as the start of the line where the left bracket is.
      Open

             ]
      Severity: Minor
      Found in lib/cc/rubymotion_cops.rb by rubocop

      This cop checks the indentation of the first element in an array literal where the opening bracket and the first element are on separate lines. The other elements' indentations are handled by the AlignArray cop.

      By default, array literals that are arguments in a method call with parentheses, and where the opening square bracket of the array is on the same line as the opening parenthesis of the method call, shall have their first element indented one step (two spaces) more than the position inside the opening parenthesis.

      Other array literals shall have their first element indented one step more than the start of the line where the opening square bracket is.

      This default style is called 'specialinsideparentheses'. Alternative styles are 'consistent' and 'align_brackets'. Here are examples:

      Example: EnforcedStyle: specialinsideparentheses (default)

      # The `special_inside_parentheses` style enforces that the first
      # element in an array literal where the opening bracket and first
      # element are on seprate lines is indented one step (two spaces) more
      # than the position inside the opening parenthesis.
      
      #bad
      array = [
        :value
      ]
      and_in_a_method_call([
        :no_difference
                           ])
      
      #good
      array = [
        :value
      ]
      but_in_a_method_call([
                             :its_like_this
                           ])

      Example: EnforcedStyle: consistent

      # The `consistent` style enforces that the first element in an array
      # literal where the opening bracket and the first element are on
      # seprate lines is indented the same as an array literal which is not
      # defined inside a method call.
      
      #bad
      # consistent
      array = [
        :value
      ]
      but_in_a_method_call([
                             :its_like_this
      ])
      
      #good
      array = [
        :value
      ]
      and_in_a_method_call([
        :no_difference
      ])

      Example: EnforcedStyle: align_brackets

      # The `align_brackets` style enforces that the opening and closing
      # brackets are indented to the same position.
      
      #bad
      # align_brackets
      and_now_for_something = [
                                :completely_different
      ]
      
      #good
      # align_brackets
      and_now_for_something = [
                                :completely_different
                              ]

      Line is too long. [111/80]
      Open

      gem "rubocop", :git => 'https://github.com/mrb/rubocop.git', :ref => 'c4b6ae4c323172c81e0f8f18f54e4e36a03b73d1'
      Severity: Minor
      Found in Gemfile by rubocop

      Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
      Open

      gem "rubocop", :git => 'https://github.com/mrb/rubocop.git', :ref => 'c4b6ae4c323172c81e0f8f18f54e4e36a03b73d1'
      Severity: Minor
      Found in Gemfile by rubocop

      Checks if uses of quotes match the configured preference.

      Example: EnforcedStyle: single_quotes (default)

      # bad
      "No special symbols"
      "No string interpolation"
      "Just text"
      
      # good
      'No special symbols'
      'No string interpolation'
      'Just text'
      "Wait! What's #{this}!"

      Example: EnforcedStyle: double_quotes

      # bad
      'Just some text'
      'No special chars or interpolation'
      
      # good
      "Just some text"
      "No special chars or interpolation"
      "Every string in #{project} uses double_quotes"

      Space missing inside }.
      Open

                return if body.each_node.any?{|n| n.zsuper_type?}

      Checks that block braces have or don't have surrounding space inside them on configuration. For blocks taking parameters, it checks that the left brace has or doesn't have trailing space depending on configuration.

      Example: EnforcedStyle: space (default)

      # The `space` style enforces that block braces have
      # surrounding space.
      
      # bad
      some_array.each {puts e}
      
      # good
      some_array.each { puts e }

      Example: EnforcedStyle: no_space

      # The `no_space` style enforces that block braces don't
      # have surrounding space.
      
      # bad
      some_array.each { puts e }
      
      # good
      some_array.each {puts e}

      Example: EnforcedStyleForEmptyBraces: no_space (default)

      # The `no_space` EnforcedStyleForEmptyBraces style enforces that
      # block braces don't have a space in between when empty.
      
      # bad
      some_array.each {   }
      some_array.each {  }
      some_array.each { }
      
      # good
      some_array.each {}

      Example: EnforcedStyleForEmptyBraces: space

      # The `space` EnforcedStyleForEmptyBraces style enforces that
      # block braces have at least a spece in between when empty.
      
      # bad
      some_array.each {}
      
      # good
      some_array.each { }
      some_array.each {  }
      some_array.each {   }

      Example: SpaceBeforeBlockParameters: true (default)

      # The SpaceBeforeBlockParameters style set to `true` enforces that
      # there is a space between `{` and `|`. Overrides `EnforcedStyle`
      # if there is a conflict.
      
      # bad
      [1, 2, 3].each {|n| n * 2 }
      
      # good
      [1, 2, 3].each { |n| n * 2 }

      Example: SpaceBeforeBlockParameters: true

      # The SpaceBeforeBlockParameters style set to `false` enforces that
      # there is no space between `{` and `|`. Overrides `EnforcedStyle`
      # if there is a conflict.
      
      # bad
      [1, 2, 3].each { |n| n * 2 }
      
      # good
      [1, 2, 3].each {|n| n * 2 }
      Severity
      Category
      Status
      Source
      Language