Sign upLogin

HuasoFoundries/jpgraph

View on GitHub
Star
src/graph/CCBPGraph.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method Init has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function Init()
    {
        // Setup limits for color indications
        $lowx   = $this->iXMin;
        $highx  = $this->iXMax;
Severity: Major
Found in src/graph/CCBPGraph.php - About 4 hrs to fix

    Function Init has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        private function Init()
    {
        // Setup limits for color indications
        $lowx   = $this->iXMin;
        $highx  = $this->iXMax;
    Severity: Minor
    Found in src/graph/CCBPGraph.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function SetColorIndication has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function SetColorIndication(array $aSpec, array $aColors = null)
    {
        if (safe_count($aSpec) !== 3) {
            Util\JpGraphError::Raise('Specification of scale values for background indicators must be an array with three elements.');
        }
    Severity: Minor
    Found in src/graph/CCBPGraph.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method Init() has 136 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

        private function Init()
    {
        // Setup limits for color indications
        $lowx   = $this->iXMin;
        $highx  = $this->iXMax;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    The method Init() has an NPath complexity of 560. The configured NPath complexity threshold is 200.
    Open

        private function Init()
    {
        // Setup limits for color indications
        $lowx   = $this->iXMin;
        $highx  = $this->iXMax;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    NPathComplexity

    Since: 0.1

    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

    Example

    class Foo {
    function bar() {
        // lots of complicated code
    }
}

    Source https://phpmd.org/rules/codesize.html#npathcomplexity

    The method Init() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
    Open

        private function Init()
    {
        // Setup limits for color indications
        $lowx   = $this->iXMin;
        $highx  = $this->iXMax;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Avoid using undefined variables such as '$colarea' which will lead to PHP notices.
    Open

                    [$colarea[$i][0][1], $colarea[$i][1][1]],
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$colarea' which will lead to PHP notices.
    Open

                $colarea[$i] = [[$lowx, $lowx * $k + $b], [$highx, $highx * $k + $b]];
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$colarea' which will lead to PHP notices.
    Open

            $colarea[3] = [[$lowx, $highy], [$highx, $highy]];
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$colarea' which will lead to PHP notices.
    Open

                    [$colarea[$i][0][0], $colarea[$i][1][0]]
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$colarea' which will lead to PHP notices.
    Open

                    [$colarea[$i][0][0], $colarea[$i][1][0]]
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$colarea' which will lead to PHP notices.
    Open

                    [$colarea[$i][0][1], $colarea[$i][1][1]],
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    The method Init uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $labelsize = 11;
        }
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method Add uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $this->iPlots[] = $aPlots;
        }
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method Init uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $graph->xaxis->SetColor('darkgray', 'darkgray:0.8');
            $graph->yaxis->SetColor('darkgray', 'darkgray:0.8');
        }
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method SetColorIndication uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                Util\JpGraphError::Raise('Color specification for background indication must have four colors.');
            }
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'SetColorIndication'.
    Open

                Util\JpGraphError::Raise('Specification of scale values for background indicators must be an array with three elements.');
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'SetColorIndication'.
    Open

                    Util\JpGraphError::Raise('Color specification for background indication must have four colors.');
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid variables with short names like $b. Configured minimum length is 3.
    Open

                $b           = $this->iColorInd[$i][0];
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $n. Configured minimum length is 3.
    Open

            $n = 3;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $cb. Configured minimum length is 3.
    Open

            $cb = [];
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $k. Configured minimum length is 3.
    Open

                $k           = ($this->iColorInd[$i][1] - $this->iColorInd[$i][0]) / $this->iXMax;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $n2. Configured minimum length is 3.
    Open

            $n2 = floor($this->iXMax / 25);
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $tm. Configured minimum length is 3.
    Open

            $tm = 60;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $lm. Configured minimum length is 3.
    Open

            $lm = 50;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $n1. Configured minimum length is 3.
    Open

            $n1 = floor(abs($this->iXMin / 25)) + 1;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $df. Configured minimum length is 3.
    Open

            $df = 'D j:S M, Y';
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $rm. Configured minimum length is 3.
    Open

            $rm = 40;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $bm. Configured minimum length is 3.
    Open

            $bm = 40;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Method name "CCBPGraph::SetColorIndication" is not in camel caps format
    Open

        public function SetColorIndication(array $aSpec, array $aColors = null)
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Class constants must be uppercase; expected NCOLORMAPS but found NColorMaps
    Open

        const NColorMaps = 2;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Method name "CCBPGraph::SetYMinMax" is not in camel caps format
    Open

        public function SetYMinMax($aMin, $aMax)
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Method name "CCBPGraph::Init" is not in camel caps format
    Open

        private function Init()
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Class constants must be uppercase; expected YTITLE but found YTitle
    Open

        const YTitle     = '% Buffer used';
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Class constants must be uppercase; expected TICKSTEP but found TickStep
    Open

        const TickStep   = 25;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Class constants must be uppercase; expected XTITLE but found XTitle
    Open

        const XTitle     = '% CC Completed';
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Method name "CCBPGraph::SetColorMap" is not in camel caps format
    Open

        public function SetColorMap($aMap)
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Method name "CCBPGraph::Add" is not in camel caps format
    Open

        public function Add($aPlots)
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Method name "CCBPGraph::SetTitle" is not in camel caps format
    Open

        public function SetTitle($aTitle, $aSubTitle)
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Method name "CCBPGraph::SetXMinMax" is not in camel caps format
    Open

        public function SetXMinMax($aMin, $aMax)
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Method name "CCBPGraph::Stroke" is not in camel caps format
    Open

        public function Stroke($aFile = '')
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    Constant XTitle should be defined in uppercase
    Open

        const XTitle     = '% CC Completed';
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ConstantNamingConventions

    Since: 0.2

    Class/Interface constant names should always be defined in uppercase.

    Example

    class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

    Source https://phpmd.org/rules/naming.html#constantnamingconventions

    Constant YTitle should be defined in uppercase
    Open

        const YTitle     = '% Buffer used';
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ConstantNamingConventions

    Since: 0.2

    Class/Interface constant names should always be defined in uppercase.

    Example

    class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

    Source https://phpmd.org/rules/naming.html#constantnamingconventions

    Constant TickStep should be defined in uppercase
    Open

        const TickStep   = 25;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ConstantNamingConventions

    Since: 0.2

    Class/Interface constant names should always be defined in uppercase.

    Example

    class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

    Source https://phpmd.org/rules/naming.html#constantnamingconventions

    Constant NColorMaps should be defined in uppercase
    Open

        const NColorMaps = 2;
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpmd

    ConstantNamingConventions

    Since: 0.2

    Class/Interface constant names should always be defined in uppercase.

    Example

    class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

    Source https://phpmd.org/rules/naming.html#constantnamingconventions

    Line exceeds 120 characters; contains 134 characters
    Open

                Util\JpGraphError::Raise('Specification of scale values for background indicators must be an array with three elements.');
    Severity: Minor
    Found in src/graph/CCBPGraph.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status